Fix rbac ServiceAccount imagePullSecrets template (#1953)

Fix rbac ServiceAccount imagePullSecrets template.

Problem: NGF fails to deploy with NGINX+ because of the rbac ServiceAccount imagePullSecrets template error.

Solution: Fix the spacing which moves imagePullSecrets from being in the ServiceAccount's metadata to its own field.

Author: bjee19

charts/nginx-gateway-fabric/templates/rbac.yaml

@@ -7,17 +7,17 @@ metadata:
   {{- include "nginx-gateway.labels" . | nindent 4 }}
   annotations:
     {{- toYaml .Values.serviceAccount.annotations | nindent 4 }}
-  {{- if or .Values.serviceAccount.imagePullSecret .Values.serviceAccount.imagePullSecrets }}
-  imagePullSecrets:
-    {{- if .Values.serviceAccount.imagePullSecret }}
-    - name: {{ .Values.serviceAccount.imagePullSecret }}
-    {{- end }}
-    {{- if .Values.serviceAccount.imagePullSecrets }}
-    {{- range .Values.serviceAccount.imagePullSecrets }}
-    - name: {{ . }}
-    {{- end }}
-    {{- end }}
+{{- if or .Values.serviceAccount.imagePullSecret .Values.serviceAccount.imagePullSecrets }}
+imagePullSecrets:
+  {{- if .Values.serviceAccount.imagePullSecret }}
+  - name: {{ .Values.serviceAccount.imagePullSecret }}
   {{- end }}
+  {{- if .Values.serviceAccount.imagePullSecrets }}
+  {{- range .Values.serviceAccount.imagePullSecrets }}
+  - name: {{ . }}
+  {{- end }}
+  {{- end }}
+{{- end }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole