Skip to content

Commit ddff374

Browse files
committed
Refactor waitForRoutesToBeReady to use parentrefs instead of status
1 parent 9c4fe3f commit ddff374

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

tests/framework/resourcemanager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ func (rm *ResourceManager) waitForRoutesToBeReady(ctx context.Context, namespace
314314

315315
var numParents, readyCount int
316316
for _, route := range routeList.Items {
317-
numParents += len(route.Status.Parents) // extract from the parentref not the status.
317+
numParents += len(route.Spec.ParentRefs)
318318
for _, parent := range route.Status.Parents {
319319
for _, cond := range parent.Conditions {
320320
if cond.Type == string(v1.RouteConditionAccepted) && cond.Status == metav1.ConditionTrue {

tests/suite/graceful_recovery_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("nfr", "graceful-recov
8686
Expect(err).ToNot(HaveOccurred())
8787

8888
Expect(resourceManager.ApplyFromFiles(files, ns.Name)).To(Succeed())
89-
time.Sleep(2 * time.Second)
9089
Expect(resourceManager.WaitForAppsToBeReady(ns.Name)).To(Succeed())
9190

9291
err = waitForWorkingTraffic()
@@ -117,7 +116,6 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("nfr", "graceful-recov
117116
Expect(err).ToNot(HaveOccurred())
118117

119118
Expect(resourceManager.ApplyFromFiles(files, ns.Name)).To(Succeed())
120-
time.Sleep(2 * time.Second)
121119
Expect(resourceManager.WaitForAppsToBeReady(ns.Name)).To(Succeed())
122120

123121
err = waitForWorkingTraffic()

0 commit comments

Comments
 (0)