Address code review comments

Author: sjberman

internal/state/dataplane/configuration.go

@@ -232,7 +232,7 @@ func (hpr *hostPathRules) upsertListener(l *graph.Listener) {
 		for _, h := range hostnames {
 			if prevListener, exists := hpr.listenersForHost[h]; exists {
 				// override the previous listener if the new one has a more specific hostname
-				if hostnameMoreSpecific(l.Source.Hostname, prevListener.Source.Hostname) {
+				if listenerHostnameMoreSpecific(l.Source.Hostname, prevListener.Source.Hostname) {
 					hpr.listenersForHost[h] = l
 				}
 			} else {
@@ -443,7 +443,7 @@ func convertPathType(pathType v1beta1.PathMatchType) PathType {
 	}
 }
 
-// Returns true if host1 is more specific than host2 (using length).
+// listenerHostnameMoreSpecific returns true if host1 is more specific than host2 (using length).
 //
 // FIXME(sberman): Since the only caller of this function specifies listener hostnames that are both
 // bound to the same route hostname, this function assumes that host1 and host2 match, either
@@ -458,7 +458,7 @@ func convertPathType(pathType v1beta1.PathMatchType) PathType {
 // As we add regex support, we should put in the proper
 // validation and error handling for this function to ensure that the hostnames are actually matching,
 // to avoid the unintended inputs above for the invalid case.
-func hostnameMoreSpecific(host1, host2 *v1beta1.Hostname) bool {
+func listenerHostnameMoreSpecific(host1, host2 *v1beta1.Hostname) bool {
 	var host1Str, host2Str string
 	if host1 == nil {
 		host1Str = ""

internal/state/dataplane/configuration_test.go

@@ -1749,6 +1749,6 @@ func TestHostnameMoreSpecific(t *testing.T) {
 	}
 
 	for _, tc := range tests {
-		g.Expect(hostnameMoreSpecific(tc.host1, tc.host2)).To(Equal(tc.host1Wins), tc.msg)
+		g.Expect(listenerHostnameMoreSpecific(tc.host1, tc.host2)).To(Equal(tc.host1Wins), tc.msg)
 	}
 }

internal/state/graph/httproute.go

@@ -340,10 +340,10 @@ func bindRouteToListeners(r *Route, gw *Gateway) {
 			return true
 		}
 
-		var valid bool
+		var validListener bool
 		if getSectionName(routeRef.SectionName) == "" {
 			for _, l := range gw.Listeners {
-				valid = bind(l) || valid
+				validListener = bind(l) || validListener
 			}
 		} else {
 			l, exists := gw.Listeners[string(*routeRef.SectionName)]
@@ -354,9 +354,9 @@ func bindRouteToListeners(r *Route, gw *Gateway) {
 				continue
 			}
 
-			valid = bind(l)
+			validListener = bind(l)
 		}
-		if !valid {
+		if !validListener {
 			attachment.FailedCondition = conditions.NewRouteInvalidListener()
 			continue
 		}

internal/state/graph/httproute_test.go

@@ -872,6 +872,29 @@ func TestBindRouteToListeners(t *testing.T) {
 			},
 			name: "section name is empty",
 		},
+		{
+			route: routeWithEmptySectionName,
+			gateway: &Gateway{
+				Source: gw,
+				Listeners: map[string]*Listener{
+					"listener-80-1": notValidListener,
+				},
+			},
+			expectedSectionNameRefs: []ParentRef{
+				{
+					Idx:     0,
+					Gateway: client.ObjectKeyFromObject(gw),
+					Attachment: &ParentRefAttachmentStatus{
+						Attached:        false,
+						FailedCondition: conditions.NewRouteInvalidListener(),
+					},
+				},
+			},
+			expectedGatewayListeners: map[string]*Listener{
+				"listener-80-1": notValidListener,
+			},
+			name: "empty section name with no valid listeners",
+		},
 		{
 			route: routeWithPort,
 			gateway: &Gateway{