Skip to content

Commit bf55cd7

Browse files
committed
Add FIXME on issues
1 parent 19f98ab commit bf55cd7

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/suite/reconfig_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("reconfig
105105
}
106106

107107
createResourcesGWLast := func(resourceCount int) {
108-
ctx, cancel := context.WithTimeout(context.Background(), timeoutConfig.CreateTimeout)
108+
ctx, cancel := context.WithTimeout(context.Background(), timeoutConfig.CreateTimeout*5)
109109
defer cancel()
110110

111111
for i := 1; i <= resourceCount; i++ {
@@ -142,7 +142,7 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("reconfig
142142
}
143143

144144
createResourcesRoutesLast := func(resourceCount int) {
145-
ctx, cancel := context.WithTimeout(context.Background(), timeoutConfig.CreateTimeout)
145+
ctx, cancel := context.WithTimeout(context.Background(), timeoutConfig.CreateTimeout*5)
146146
defer cancel()
147147

148148
for i := 1; i <= resourceCount; i++ {
@@ -205,6 +205,8 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("reconfig
205205
cleanupResources := func() error {
206206
var err error
207207

208+
// FIXME (bjee19): https://github.com/nginxinc/nginx-gateway-fabric/issues/2376
209+
// Find a way to bulk delete these namespaces.
208210
for i := 1; i <= maxResourceCount; i++ {
209211
nsName := "namespace" + strconv.Itoa(i)
210212
resultError := resourceManager.DeleteNamespace(nsName)
@@ -422,6 +424,8 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("reconfig
422424
})
423425
Expect(err).ToNot(HaveOccurred())
424426

427+
// FIXME (bjee19): https://github.com/nginxinc/nginx-gateway-fabric/issues/2374
428+
// Find a way to calculate time to ready metrics without having to rely on specific log lines.
425429
timeToReadyTotal, err := calculateTimeToReadyTotal(logs, timeToReadyStartingLogSubstring)
426430
Expect(err).ToNot(HaveOccurred())
427431

0 commit comments

Comments
 (0)