Remove unused functions and fix GetPointer on type int32

Author: bjee19

internal/framework/helpers/helpers.go

@@ -6,7 +6,6 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"sigs.k8s.io/gateway-api/apis/v1beta1"
 )
 
 // Diff prints the diff between two structs.
@@ -21,46 +20,6 @@ func Diff(want, got any) string {
 	return r
 }
 
-// GetStringPointer takes a string and returns a pointer to it.
-func GetStringPointer(s string) *string {
-	return &s
-}
-
-// GetIntPointer takes an int and returns a pointer to it.
-func GetIntPointer(i int) *int {
-	return &i
-}
-
-// GetInt32Pointer takes an int32 and returns a pointer to it.
-func GetInt32Pointer(i int32) *int32 {
-	return &i
-}
-
-// GetHTTPMethodPointer takes an HTTPMethod and returns a pointer to it.
-func GetHTTPMethodPointer(m v1beta1.HTTPMethod) *v1beta1.HTTPMethod {
-	return &m
-}
-
-// GetHeaderMatchTypePointer takes an HeaderMatchType and returns a pointer to it.
-func GetHeaderMatchTypePointer(t v1beta1.HeaderMatchType) *v1beta1.HeaderMatchType {
-	return &t
-}
-
-// GetQueryParamMatchTypePointer takes an QueryParamMatchType and returns a pointer to it.
-func GetQueryParamMatchTypePointer(t v1beta1.QueryParamMatchType) *v1beta1.QueryParamMatchType {
-	return &t
-}
-
-// GetTLSModePointer takes a TLSModeType and returns a pointer to it.
-func GetTLSModePointer(t v1beta1.TLSModeType) *v1beta1.TLSModeType {
-	return &t
-}
-
-// GetBoolPointer takes a bool and returns a pointer to it.
-func GetBoolPointer(b bool) *bool {
-	return &b
-}
-
 // GetPointer takes a value of any type and returns a pointer to it.
 func GetPointer[T any](v T) *T {
 	return &v

internal/mode/static/state/graph/graph_test.go

@@ -66,7 +66,7 @@ func TestBuildGraph(t *testing.T) {
 										Kind:      (*v1beta1.Kind)(helpers.GetPointer("Service")),
 										Name:      "foo",
 										Namespace: (*v1beta1.Namespace)(helpers.GetPointer("service")),
-										Port:      (*v1beta1.PortNumber)(helpers.GetPointer(int32(80))),
+										Port:      (*v1beta1.PortNumber)(helpers.GetPointer[int32](80)),
 									},
 								},
 							},

internal/mode/static/state/relationship/relationships_test.go

@@ -20,7 +20,7 @@ func TestGetBackendServiceNamesFromRoute(t *testing.T) {
 						Kind:      (*v1beta1.Kind)(helpers.GetPointer("Service")),
 						Name:      svcName,
 						Namespace: (*v1beta1.Namespace)(helpers.GetPointer("test")),
-						Port:      (*v1beta1.PortNumber)(helpers.GetPointer(int32(80))),
+						Port:      (*v1beta1.PortNumber)(helpers.GetPointer[int32](80)),
 					},
 				},
 			},
@@ -94,7 +94,7 @@ func TestGetBackendServiceNamesFromRoute(t *testing.T) {
 											helpers.GetPointer("test"),
 										),
 										Port: (*v1beta1.PortNumber)(
-											helpers.GetPointer(int32(80)),
+											helpers.GetPointer[int32](80),
 										),
 									},
 								},

internal/mode/static/state/resolver/resolver_test.go

@@ -34,7 +34,7 @@ var (
 		Ports: []discoveryV1.EndpointPort{
 			{
 				Name: &svcPortName,
-				Port: helpers.GetPointer(int32(80)),
+				Port: helpers.GetPointer[int32](80),
 			},
 		},
 	}
@@ -54,7 +54,7 @@ var (
 		Ports: []discoveryV1.EndpointPort{
 			{
 				Name: &svcPortName,
-				Port: helpers.GetPointer(int32(80)),
+				Port: helpers.GetPointer[int32](80),
 			},
 		},
 	}
@@ -65,7 +65,7 @@ var (
 		Ports: []discoveryV1.EndpointPort{
 			{
 				Name: &svcPortName,
-				Port: helpers.GetPointer(int32(80)),
+				Port: helpers.GetPointer[int32](80),
 			},
 		},
 	}
@@ -76,7 +76,7 @@ var (
 		Ports: []discoveryV1.EndpointPort{
 			{
 				Name: helpers.GetPointer("other-svc-port"),
-				Port: helpers.GetPointer(int32(8080)),
+				Port: helpers.GetPointer[int32](8080),
 			},
 		},
 	}
@@ -387,7 +387,7 @@ func TestFindPort(t *testing.T) {
 			ports: []discoveryV1.EndpointPort{
 				{
 					Name: nil,
-					Port: helpers.GetPointer(int32(8080)),
+					Port: helpers.GetPointer[int32](8080),
 				},
 			},
 			svcPort: v1.ServicePort{
@@ -402,15 +402,15 @@ func TestFindPort(t *testing.T) {
 			ports: []discoveryV1.EndpointPort{
 				{
 					Name: helpers.GetPointer("other-svc-port"),
-					Port: helpers.GetPointer(int32(8080)),
+					Port: helpers.GetPointer[int32](8080),
 				},
 				{
 					Name: helpers.GetPointer("other-svc-port2"),
-					Port: helpers.GetPointer(int32(8081)),
+					Port: helpers.GetPointer[int32](8081),
 				},
 				{
 					Name: helpers.GetPointer("other-svc-port3"),
-					Port: helpers.GetPointer(int32(8082)),
+					Port: helpers.GetPointer[int32](8082),
 				},
 			},
 			svcPort: v1.ServicePort{
@@ -425,15 +425,15 @@ func TestFindPort(t *testing.T) {
 			ports: []discoveryV1.EndpointPort{
 				{
 					Name: helpers.GetPointer("other-svc-port"),
-					Port: helpers.GetPointer(int32(8080)),
+					Port: helpers.GetPointer[int32](8080),
 				},
 				{
 					Name: helpers.GetPointer("other-svc-port2"),
-					Port: helpers.GetPointer(int32(8081)),
+					Port: helpers.GetPointer[int32](8081),
 				},
 				{
 					Name: &svcPortName, // match
-					Port: helpers.GetPointer(int32(8082)),
+					Port: helpers.GetPointer[int32](8082),
 				},
 			},
 			svcPort: v1.ServicePort{
@@ -449,7 +449,7 @@ func TestFindPort(t *testing.T) {
 				{
 					// If a service port is unnamed (empty string), then the endpoint port will also be empty string.
 					Name: helpers.GetPointer(""),
-					Port: helpers.GetPointer(int32(8080)),
+					Port: helpers.GetPointer[int32](8080),
 				},
 			},
 			svcPort: v1.ServicePort{