Skip to content

Commit 8a6adbf

Browse files
authored
Fix doc mistakes and remove unused test variables (#252)
Resolve overlooked merge conflict in Gateway API Compatibility and remove unused test variables.
1 parent c4a0727 commit 8a6adbf

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

docs/gateway-api-compatibility.md.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,11 @@ Fields:
8787
* `headers` - partially supported. Only `Exact` type.
8888
* `queryParams` - partially supported. Only `Exact` type.
8989
* `method` - supported.
90-
<<<<<<< HEAD
9190
* `filters`
9291
* `type` - supported.
9392
* `requestRedirect` - supported except for the experimental `path` field. If multiple filters with `requestRedirect` are configured, NGINX Kubernetes Gateway will choose the first one and ignore the rest.
9493
* `requestHeaderModifier`, `requestMirror`, `urlRewrite`, `extensionRef` - not supported.
95-
* `backendRefs` - partially supported. Only a single backend ref without support for `weight`. Backend ref `filters` are not supported. NGINX Kubernetes Gateway will use the IP of the Service as a backend, not the IPs of the corresponding Pods. Watching for Service updates is not supported.
96-
=======
97-
* `filters` - not supported.
9894
* `backendRefs` - partially supported. Only a single backend ref without support for `weight`. Backend ref `filters` are not supported.
99-
>>>>>>> 1697a08... Add support for dynamic upstreams
10095
* `status`
10196
* `parents`
10297
* `parentRef` - supported.

internal/nginx/config/generator_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,7 @@ func TestGenerateForDefaultServers(t *testing.T) {
142142

143143
func TestGenerateHTTPServers(t *testing.T) {
144144
const (
145-
backendAddr = "http://10.0.0.1:80"
146-
certPath = "/etc/nginx/secrets/cert"
147-
http = false
148-
https = true
145+
certPath = "/etc/nginx/secrets/cert"
149146
)
150147

151148
hr := &v1beta1.HTTPRoute{

0 commit comments

Comments
 (0)