Skip to content

Commit 73322c5

Browse files
committed
Use GetAPIReader and fix RBAC
1 parent 2b07365 commit 73322c5

File tree

3 files changed

+35
-17
lines changed

3 files changed

+35
-17
lines changed

deploy/helm-chart/templates/rbac.yaml

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,23 @@ rules:
2121
- namespaces
2222
- services
2323
- secrets
24-
# FIXME(bjee19): make nodes permission dependent on telemetry being enabled.
25-
# https://github.com/nginxinc/nginx-gateway-fabric/issues/1317.
26-
- nodes
27-
- pods
2824
verbs:
2925
- list
3026
- watch
27+
# FIXME(bjee19): make nodes, pods, replicasets permission dependent on telemetry being enabled.
28+
# https://github.com/nginxinc/nginx-gateway-fabric/issues/1317.
29+
- apiGroups:
30+
- ""
31+
resources:
32+
- pods
33+
verbs:
34+
- get
35+
- apiGroups:
36+
- ""
37+
resources:
38+
- nodes
39+
verbs:
40+
- list
3141
- apiGroups:
3242
- ""
3343
resources:
@@ -36,12 +46,11 @@ rules:
3646
- create
3747
- patch
3848
- apiGroups:
39-
- apps
49+
- apps
4050
resources:
41-
- replicasets
51+
- replicasets
4252
verbs:
43-
- list
44-
- watch
53+
- get
4554
- apiGroups:
4655
- discovery.k8s.io
4756
resources:

deploy/manifests/nginx-gateway.yaml

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,23 @@ rules:
3232
- namespaces
3333
- services
3434
- secrets
35-
# FIXME(bjee19): make nodes permission dependent on telemetry being enabled.
36-
# https://github.com/nginxinc/nginx-gateway-fabric/issues/1317.
37-
- nodes
38-
- pods
3935
verbs:
4036
- list
4137
- watch
38+
# FIXME(bjee19): make nodes, pods, replicasets permission dependent on telemetry being enabled.
39+
# https://github.com/nginxinc/nginx-gateway-fabric/issues/1317.
40+
- apiGroups:
41+
- ""
42+
resources:
43+
- pods
44+
verbs:
45+
- get
46+
- apiGroups:
47+
- ""
48+
resources:
49+
- nodes
50+
verbs:
51+
- list
4252
- apiGroups:
4353
- ""
4454
resources:
@@ -47,12 +57,11 @@ rules:
4757
- create
4858
- patch
4959
- apiGroups:
50-
- apps
60+
- apps
5161
resources:
52-
- replicasets
62+
- replicasets
5363
verbs:
54-
- list
55-
- watch
64+
- get
5665
- apiGroups:
5766
- discovery.k8s.io
5867
resources:

internal/mode/static/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ func StartManager(cfg config.Config) error {
216216
}
217217

218218
dataCollector := telemetry.NewDataCollectorImpl(telemetry.DataCollectorConfig{
219-
K8sClientReader: mgr.GetClient(),
219+
K8sClientReader: mgr.GetAPIReader(),
220220
GraphGetter: processor,
221221
ConfigurationGetter: eventHandler,
222222
Version: cfg.Version,

0 commit comments

Comments
 (0)