Add logic for defining port in redirect based on scheme

Author: ciarams87

internal/nginx/config/servers.go

@@ -198,6 +198,14 @@ func createReturnValForRedirectFilter(filter *v1beta1.HTTPRequestRedirectFilter,
 	port := listenerPort
 	if filter.Port != nil {
 		port = int32(*filter.Port)
+	} else {
+		if filter.Scheme != nil {
+			if *filter.Scheme == "http" {
+				port = 80
+			} else if *filter.Scheme == "https" {
+				port = 443
+			}
+		}
 	}
 
 	scheme := "$scheme"

internal/nginx/config/servers_test.go

@@ -913,6 +913,42 @@ func TestCreateReturnValForRedirectFilter(t *testing.T) {
 			},
 			msg: "all fields are set",
 		},
+		{
+			filter: &v1beta1.HTTPRequestRedirectFilter{
+				Scheme:     helpers.GetStringPointer("https"),
+				Hostname:   (*v1beta1.PreciseHostname)(helpers.GetStringPointer("foo.example.com")),
+				StatusCode: helpers.GetIntPointer(101),
+			},
+			expected: &http.Return{
+				Code: 101,
+				Body: "https://foo.example.com:443$request_uri",
+			},
+			msg: "scheme is https, no port is set",
+		},
+		{
+			filter: &v1beta1.HTTPRequestRedirectFilter{
+				Scheme:     helpers.GetStringPointer("http"),
+				Hostname:   (*v1beta1.PreciseHostname)(helpers.GetStringPointer("foo.example.com")),
+				StatusCode: helpers.GetIntPointer(101),
+			},
+			expected: &http.Return{
+				Code: 101,
+				Body: "http://foo.example.com:80$request_uri",
+			},
+			msg: "scheme is http, no port is set",
+		},
+		{
+			filter: &v1beta1.HTTPRequestRedirectFilter{
+				Scheme:     helpers.GetStringPointer("custom"),
+				Hostname:   (*v1beta1.PreciseHostname)(helpers.GetStringPointer("foo.example.com")),
+				StatusCode: helpers.GetIntPointer(101),
+			},
+			expected: &http.Return{
+				Code: 101,
+				Body: "custom://foo.example.com:123$request_uri",
+			},
+			msg: "scheme is custom, no port is set",
+		},
 	}
 
 	for _, test := range tests {