Add check for replica being nil

Author: bjee19

internal/mode/static/telemetry/collector.go

@@ -170,10 +170,10 @@ func collectNGFReplicaCount(ctx context.Context, k8sClient client.Reader, podNSN
 
 	podOwnerRefs := pod.GetOwnerReferences()
 	if podOwnerRefs == nil {
-		return 0, fmt.Errorf("could not get owner reference of NGF Pod")
+		return 0, errors.New("could not get owner reference of NGF Pod")
 	}
 	if len(podOwnerRefs) != 1 {
-		return 0, fmt.Errorf("multiple owner references of NGF Pod")
+		return 0, errors.New("multiple owner references of NGF Pod")
 	}
 
 	switch kind := podOwnerRefs[0].Kind; kind {
@@ -186,6 +186,10 @@ func collectNGFReplicaCount(ctx context.Context, k8sClient client.Reader, podNSN
 			return 0, err
 		}
 
+		if replicaSet.Spec.Replicas == nil {
+			return 0, errors.New("replica set replicas was nil")
+		}
+
 		return int(*replicaSet.Spec.Replicas), nil
 	default:
 		return 0, fmt.Errorf("pod owner reference was not ReplicaSet, instead was %s", kind)

internal/mode/static/telemetry/collector_test.go

@@ -497,6 +497,36 @@ var _ = Describe("Collector", Ordered, func() {
 					Expect(err).To(HaveOccurred())
 				})
 
+				It("should error if the replica set's replicas is nil", func() {
+					k8sClientReader.GetCalls(
+						func(ctx context.Context, key client.ObjectKey, object client.Object, option ...client.GetOption) error {
+							Expect(option).To(BeEmpty())
+
+							switch typedObj := object.(type) {
+							case *v1.Pod:
+								typedObj.ObjectMeta = metav1.ObjectMeta{
+									Name: "pod1",
+									OwnerReferences: []metav1.OwnerReference{
+										{
+											Kind: "ReplicaSet",
+											Name: "replicaset1",
+										},
+									},
+								}
+							case *appsv1.ReplicaSet:
+								typedObj.Spec = appsv1.ReplicaSetSpec{
+									Replicas: nil,
+								}
+							default:
+								Fail(fmt.Sprintf("unknown type: %T", typedObj))
+							}
+							return nil
+						})
+
+					_, err := dataCollector.Collect(ctx)
+					Expect(err).To(HaveOccurred())
+				})
+
 				It("should error if the kubernetes client errored when getting the ReplicaSet", func() {
 					k8sClientReader.GetReturnsOnCall(1, errors.New("there was an error"))