Skip to content

Commit 3b07215

Browse files
ciarams87sjberman
andauthored
Apply suggestions from code review
Co-authored-by: Saylor Berman <s.berman@f5.com>
1 parent dc4828e commit 3b07215

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

apis/v1alpha1/nginxproxy_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ type NginxProxySpec struct {
3636
// Default is false, meaning http2 will be enabled for all servers.
3737
//
3838
// +optional
39-
DisableHTTP2 bool `json:"disableHTTP2"`
39+
DisableHTTP2 bool `json:"disableHTTP2,omitempty"`
4040
}
4141

4242
// Telemetry specifies the OpenTelemetry configuration.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package config
22

33
const baseHTTPTemplateText = `
4-
{{- if .HTTP2 }}http2 on;{{- end }}
4+
{{- if .HTTP2 }}http2 on;{{ end }}
55
`

internal/mode/static/state/dataplane/types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,8 @@ type SpanAttribute struct {
282282
Value string
283283
}
284284

285-
// BaseHTTPConfig holds the configuration options at the http context
285+
// BaseHTTPConfig holds the configuration options at the http context.
286286
type BaseHTTPConfig struct {
287-
// HTTP2 specifies whether http2 should be enabled or disabled for all servers
287+
// HTTP2 specifies whether http2 should be enabled or disabled for all servers.
288288
HTTP2 bool
289289
}

0 commit comments

Comments
 (0)