Use chart-testing to lint the Helm Chart (#2027)

Use chart-testing to lint the Helm Chart

Problem: We want to validate all the files related to the helm chart and not just run helm lint

Solution: Use helm/chart-testing

Author: lucacome

.ct.yaml

@@ -0,0 +1,4 @@
+remote: origin
+target-branch: main
+
+check-version-increment: false

.github/workflows/lint.yml

@@ -99,8 +99,20 @@ jobs:
     steps:
       - name: Checkout Repository
         uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
-      - name: Lint chart
-        run: make lint-helm
+        with:
+          fetch-depth: 0
+
+      - name: Set up Python
+        uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
+        with:
+          python-version: "3.x"
+          check-latest: true
+
+      - name: Set up chart-testing
+        uses: helm/chart-testing-action@e6669bcd63d7cb57cb4380c33043eebe5d111992 # v2.6.1
+
+      - name: Run chart-testing
+        run: ct lint --print-config --config .ct.yaml
 
   yaml-lint:
     name: Yaml Lint

.yamllint.yaml

@@ -4,7 +4,7 @@ yaml-files:
   - "*.yml"
 
 ignore:
-  - charts/nginx-gateway-fabric/templates
+  - charts/nginx-gateway-fabric/
   - config/crd/bases/
   - deploy/crds.yaml
 

Makefile

@@ -191,7 +191,7 @@ njs-unit-test: ## Run unit tests for the njs httpmatches module
 
 .PHONY: lint-helm
 lint-helm: ## Run the helm chart linter
-	helm lint $(CHART_DIR)
+	docker run --pull always --rm -v $(CURDIR):/nginx-gateway-fabric -w /nginx-gateway-fabric quay.io/helmpack/chart-testing:latest ct lint --config .ct.yaml
 
 .PHONY: load-images
 load-images: ## Load NGF and NGINX images on configured kind cluster.

charts/nginx-gateway-fabric/Chart.yaml

@@ -14,5 +14,5 @@ keywords:
   - gateway
   - nginx
 maintainers:
-  - name: nginxinc
+  - name: nginxinc/nginx-gateway-fabric
     email: kubernetes@nginx.com