Skip to content

Commit 01c9dfa

Browse files
committed
Remove unused data from persistedGVKs
Both apiv1.Namespace and apiv1.Service are stored in persistedGVKs. However, setting either store or predicate to nil implies that a state change will not trigger a graph rebuild. In such cases, only Capturer can trigger the graph rebuild, and Capturer does not require information from either store or predicate. Therefore, store and predicate should be either both set or both unset. This PR sets `store: nil` for both apiv1.Namespace and apiv1.Service
1 parent 3d38822 commit 01c9dfa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

internal/mode/static/state/change_processor.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,12 @@ func NewChangeProcessorImpl(cfg ChangeProcessorConfig) *ChangeProcessorImpl {
145145
},
146146
{
147147
gvk: extractGVK(&apiv1.Namespace{}),
148-
store: newObjectStoreMapAdapter(clusterStore.Namespaces),
148+
store: nil,
149149
predicate: nil,
150150
},
151151
{
152152
gvk: extractGVK(&apiv1.Service{}),
153-
store: newObjectStoreMapAdapter(clusterStore.Services),
153+
store: nil,
154154
predicate: nil,
155155
},
156156
{

0 commit comments

Comments
 (0)