fix: remove unused dependencies, add undeclared dependencies #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eslint config is broken anyway, so I also removed the reference to an eslint dependency that wasn't declared as a dependency in the right package and would have just happened to work due to hoisting.
These just happened to work due to dependency tree hoisting, but could have easily broken in the future. This should have been caught by eslint, but that's broken too.
JakeChampion
approved these changes
May 27, 2025
serhalp
deleted the
serhalp/frb-1854-add-missing-undeclared-npm-dependencies
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused dependencies 5e684fa
Note that the eslint config is broken anyway (fix underway in another PR), so I also removed the reference to an eslint dependency that wasn't declared as a dependency in the right package and would have just happened to work due to hoisting.
Declare undeclared dependencies 2ed5bb5
These happened to work for now due to npm
node_modulesdependency hoisting.This should have been caught by eslint, but that's broken too (work underway in another PR).