fix 404 cypress tests which expect root level 404.html

Author: lindsaylevine

cypress/integration/i18n_spec.js

@@ -210,7 +210,7 @@ describe("getServerSideProps", () => {
         cy.state("document").write(response.body);
       });
 
-      // cy.get("h2").should("contain", "This page could not be found.");
+      cy.get("h2").should("contain", "This page could not be found.");
     });
 
     it("loads TV show with one param", () => {
@@ -328,7 +328,7 @@ describe("getStaticProps", () => {
           cy.state("document").write(response.body);
         });
 
-        // cy.get("h2").should("contain", "This page could not be found.");
+        cy.get("h2").should("contain", "This page could not be found.");
       });
     });
 
@@ -704,6 +704,6 @@ describe("404 page", () => {
       cy.state("document").write(response.body);
     });
 
-    // cy.get("h2").should("contain", "This page could not be found.");
+    cy.get("h2").should("contain", "This page could not be found.");
   });
 });

lib/pages/withoutProps/setup.js

@@ -2,6 +2,7 @@ const { join, relative } = require("path");
 const { copySync } = require("fs-extra");
 const { logTitle, logItem } = require("../../helpers/logger");
 const { NEXT_DIST_DIR } = require("../../config");
+const nextConfig = require("../../helpers/getNextConfig")();
 const setupStaticFileForPage = require("../../helpers/setupStaticFileForPage");
 const pages = require("./pages");
 
@@ -14,6 +15,17 @@ const setup = (publishPath) => {
   pages.forEach(({ filePath }) => {
     logItem(filePath);
 
+    // HACK: If i18n, Next internals expect a 404.html at the top level of the publish directory
+    // TO-DO: investigate framework and why this isn't an issue on Vercel and only certain routes
+    if (nextConfig.i18n) {
+      if (filePath === `pages/${nextConfig.i18n.defaultLocale}/404.html`) {
+        copySync(
+          join(NEXT_DIST_DIR, "serverless", filePath),
+          join(publishPath, "404.html")
+        );
+      }
+    }
+
     // The path to the file, relative to the pages directory
     const relativePath = relative("pages", filePath);
     setupStaticFileForPage({ inputPath: relativePath, publishPath });