fix: page chunk for root level catch-all is served incorrectly to client

Author: lindsaylevine

lib/steps/setupRedirects.js

@@ -50,6 +50,12 @@ const setupRedirects = () => {
     });
   });
 
+  // This redirect takes care of this issue: https://github.com/netlify/next-on-netlify/issues/43
+  // where the page chunk for a root level catch-all is served incorrectly to the client.
+  // Add last because it's least specific.
+  if (nextRedirects.length >= 1)
+    redirects.push("/_next/*  /_next/static/*  200");
+
   // Write redirects to _redirects file
   writeFileSync(join(NETLIFY_PUBLISH_PATH, "_redirects"), redirects.join("\n"));
 };

tests/__snapshots__/defaults.test.js.snap

@@ -28,5 +28,6 @@ exports[`Routing creates Netlify redirects 1`] = `
 /getStaticProps/withRevalidate/withFallback/:id  /.netlify/functions/next_getStaticProps_withRevalidate_withFallback_id  200
 /shows/:id  /.netlify/functions/next_shows_id  200
 /shows/:params/*  /.netlify/functions/next_shows_params  200
-/static/:id  /static/[id].html  200"
+/static/:id  /static/[id].html  200
+/_next/*  /_next/static/*  200"
 `;

tests/__snapshots__/optionalCatchAll.test.js.snap

@@ -7,5 +7,6 @@ exports[`Routing creates Netlify redirects 1`] = `
 /_next/data/%BUILD_ID%/*  /.netlify/functions/next_all  200
 /page  /.netlify/functions/next_page  200
 /  /.netlify/functions/next_all  200
-/*  /.netlify/functions/next_all  200"
+/*  /.netlify/functions/next_all  200
+/_next/*  /_next/static/*  200"
 `;

tests/getServerSidePropsIndexPage.test.js

@@ -56,8 +56,9 @@ describe("Routing", () => {
     expect(redirects[2]).toEqual(
       "/_next/data/%BUILD_ID%/index.json  /.netlify/functions/next_index  200"
     );
+    expect(redirects[3]).toEqual("/_next/*  /_next/static/*  200");
 
     // Check that no other redirects are present
-    expect(redirects).toHaveLength(3);
+    expect(redirects).toHaveLength(4);
   });
 });