feat: add support for experimental image remotePatterns #1375
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
|
||
| export const handler: Handler = createIPXHandler({ | ||
| basePath, | ||
| domains, | ||
| remotePatterns, | ||
| }) as Handler |
There was a problem hiding this comment.
Not related to your PR, but createIPXHandler should be returning the type Handler so there is no need to cast it as Handler. I'll make a note to make a small PR for that when I have a bit of down time.
|
The last commit re: cypress tests isn't complete, it's pending access to our Cypress dashboard (requested in slack) to create a project for the canary site, to add the |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarahetter
force-pushed
the
image-remotepatterns
branch
from
f6601a4 to
c658715
Compare
Summary
This adds support for Next's experimental remotePatterns with help from the changes I've made to our @netlify/ipx package. We are now writing the remotePatterns to file (imageconfig.js) which is then read by the ipx.ts file used by the ipx function.
I've added a demo site to be used for features that should all work with the latest Next.js canary release (12.1.7-canary.29 is what I'm using at the moment). I didn't change the
defaultdemo to the latest canary, as there are some breaking changes re: middleware that we want to wait on before investigating further.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Closes #1375
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.