From d2cebffc4585ea4136d1874c21bd5c1667e32418 Mon Sep 17 00:00:00 2001 From: Suzanne Aitchison Date: Fri, 21 Apr 2023 14:05:29 +0100 Subject: [PATCH] chrome.kill() is now sync, add extra logging for capturing similar errors in future --- src/lib/run-audit-with-server/index.js | 1 + src/lighthouse.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/run-audit-with-server/index.js b/src/lib/run-audit-with-server/index.js index c48f5a8e..04fa18bc 100644 --- a/src/lib/run-audit-with-server/index.js +++ b/src/lib/run-audit-with-server/index.js @@ -55,6 +55,7 @@ const runAuditWithServer = async ({ }; } } catch (error) { + console.warn(error); return { error }; } }; diff --git a/src/lighthouse.js b/src/lighthouse.js index 9cea356b..984812c9 100644 --- a/src/lighthouse.js +++ b/src/lighthouse.js @@ -40,7 +40,7 @@ export const runLighthouse = async (browserPath, url, settings) => { return results; } finally { if (chrome) { - await chrome.kill().catch(() => undefined); + await chrome.kill(); } } };