fix(deps): Revert "fix(deps) Upgrade puppeteer to v 19.5.2" #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa216b2.
👷 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
changed the title
aitkenster
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #532
Since merging this we've noticed a bug in CI builds where the first building using the plugin works as expected, but subsequent runs are not generating reports, unless the cache is fully cleared.
Reverting this change so we can investigate and correct.
Testing:
Internal colleagues can verify the revert is restoring expected behaviour by visiting the deploys for the plugin and observing that re-running this PR build (without any cache clearing) results in lighthouse reports being generated (and cypress tests passing) each time