Skip to content

Commit 34b4770

Browse files
committed
try directly adding to runauditwithurl
1 parent b403d03 commit 34b4770

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/lib/get-settings/index.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,7 @@ const mergeSettingsSources = (inputSettings = {}) => {
2222

2323
const getSettings = (inputSettings, isUsingDeployUrl) => {
2424
const settings = mergeSettingsSources(inputSettings);
25-
if (Object.keys(settings).length === 0) {
26-
return isUsingDeployUrl
27-
? undefined
28-
: { settings: { skipAudits: ['is-crawlable'] } };
29-
}
25+
if (Object.keys(settings).length === 0) return;
3026

3127
// Set a base-level config based on the preset input value
3228
// (desktop is currently the only supported option)

src/lib/run-audit-with-url/index.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,14 @@ const runAuditWithUrl = async ({ path = '', url, thresholds, settings }) => {
77

88
const getResults = async () => {
99
const fullPath = path ? `${url}/${path}` : url;
10-
const results = await runLighthouse(browserPath, fullPath, settings);
10+
console.log('Running lighthouse with settings', {
11+
...settings,
12+
skipAudits: ['is-crawlable'],
13+
});
14+
const results = await runLighthouse(browserPath, fullPath, {
15+
...settings,
16+
skipAudits: ['is-crawlable'],
17+
});
1118

1219
try {
1320
return { results };

0 commit comments

Comments
 (0)