Skip to content

Commit 9463872

Browse files
committed
chore: bump min to 20.19
1 parent 9a50e78 commit 9463872

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,16 @@ jobs:
1212
strategy:
1313
matrix:
1414
os: [ubuntu-latest, macOS-latest, windows-latest]
15-
node-version: [18.19.1, 20.13.1, 22]
15+
node-version: [18.19.1, 20.19.1, 22]
1616
exclude:
1717
- os: macOS-latest
1818
node-version: 18.19.1
1919
- os: windows-latest
2020
node-version: 18.19.1
2121
- os: macOS-latest
22-
node-version: 20.13.1
22+
node-version: 20.19.1
2323
- os: windows-latest
24-
node-version: 20.13.1
24+
node-version: 20.19.1
2525
fail-fast: false
2626

2727
steps:
@@ -35,6 +35,6 @@ jobs:
3535
name: NPM Install
3636
- name: Linting
3737
run: npm run format:ci
38-
if: "${{ matrix.node-version == '20.13.1' }}"
38+
if: "${{ matrix.node-version == '20.19.1' }}"
3939
- name: Run tests
4040
run: npm run test

demo/.nvmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"format:check:prettier": "cross-env-shell prettier --check $npm_package_config_prettier",
4949
"format:fix:prettier": "cross-env-shell prettier --write $npm_package_config_prettier",
5050
"prepublishOnly": "npm ci && npm test",
51-
"pretest:demo": "semver -r \"<20.11\" \"$(node -v)\" && echo \"Skipping on not supported node version (needed: >=20.11, got: $(node -v))\" || (cd demo && npm ci && netlify build --cwd . --offline)",
51+
"pretest:demo": "semver -r \"<20.19\" \"$(node -v)\" && echo \"Skipping on not supported node version (needed: >=20.19, got: $(node -v))\" || (cd demo && npm ci && netlify build --cwd . --offline)",
5252
"pretest:fixtures": "run-s pretest:fixtures:*",
5353
"pretest:fixtures:non-angular-project": "cd tests/fixtures/non-angular-project && npm ci",
5454
"pretest:fixtures:missing-angular-deps": "cd tests/fixtures/missing-angular-deps && npm ci",
@@ -60,8 +60,8 @@
6060
"pretest:fixtures:angular-19-app-engine": "cd tests/fixtures/angular-19-app-engine && npm ci",
6161
"pretest:fixtures:angular-19-app-engine-node-module-resolution": "cd tests/fixtures/angular-19-app-engine-node-module-resolution && npm ci",
6262
"pretest:fixtures:angular-19-prerender-false": "cd tests/fixtures/angular-19-prerender-false && npm ci",
63-
"pretest:fixtures:angular-20": "semver -r \"<20.11\" \"$(node -v)\" && echo \"Skipping on not supported node version (needed: >=20.11, got: $(node -v))\" || (cd tests/fixtures/angular-20 && npm ci)",
64-
"pretest:fixtures:angular-20-zoneless": "semver -r \"<20.11\" \"$(node -v)\" && echo \"Skipping on not supported node version (needed: >=20.11, got: $(node -v))\" || (cd tests/fixtures/angular-20-zoneless && npm ci)",
63+
"pretest:fixtures:angular-20": "semver -r \"<20.19\" \"$(node -v)\" && echo \"Skipping on not supported node version (needed: >=20.19, got: $(node -v))\" || (cd tests/fixtures/angular-20 && npm ci)",
64+
"pretest:fixtures:angular-20-zoneless": "semver -r \"<20.19\" \"$(node -v)\" && echo \"Skipping on not supported node version (needed: >=20.19, got: $(node -v))\" || (cd tests/fixtures/angular-20-zoneless && npm ci)",
6565
"pretest:fixtures:nx-angular-19-common-engine": "cd tests/fixtures/nx-angular-19-common-engine && npm ci",
6666
"pretest:fixtures:nx-angular-19-app-engine": "cd tests/fixtures/nx-angular-19-app-engine && npm ci",
6767
"pretest": "run-s pretest:*",

tests/integration.test.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ test('Angular 19 in an NX workspace using App Engine (Developer Preview)', async
127127
test(
128128
'Angular 20',
129129
{
130-
skip: !satisfies(versions.node, '>=20.11'),
130+
skip: !satisfies(versions.node, '>=20.19'),
131131
},
132132
async () => {
133133
const { severityCode, success } = await build({
@@ -142,7 +142,7 @@ test(
142142
test(
143143
'Angular 20 Zoneless (Developer Preview)',
144144
{
145-
skip: !satisfies(versions.node, '>=20.11'),
145+
skip: !satisfies(versions.node, '>=20.19'),
146146
},
147147
async () => {
148148
const { severityCode, success } = await build({
@@ -158,7 +158,7 @@ describe('Angular version validation', () => {
158158
test(
159159
'checks version for angular 20',
160160
{
161-
skip: !satisfies(versions.node, '>=20.11'),
161+
skip: !satisfies(versions.node, '>=20.19'),
162162
},
163163
async () => {
164164
const result = validateAngularVersion(

0 commit comments

Comments
 (0)