Skip to content

Commit 0d1759d

Browse files
committed
fix: remove @android/ssr from dev and peerDeps
1 parent ed3105e commit 0d1759d

File tree

4 files changed

+2
-282
lines changed

4 files changed

+2
-282
lines changed

package-lock.json

Lines changed: 0 additions & 247 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
"node": ">=18.13.0"
7474
},
7575
"devDependencies": {
76-
"@angular/ssr": "^19.0.0-rc.1",
7776
"@opentelemetry/api": "~1.8.0",
7877
"@netlify/eslint-config-node": "^7.0.1",
7978
"@types/node": "^18.19.0",
@@ -88,14 +87,6 @@
8887
"fs-extra": "^11.1.1",
8988
"semver": "^7.5.4"
9089
},
91-
"peerDependencies": {
92-
"@angular/ssr": "^19.0.0-rc.1"
93-
},
94-
"peerDependenciesMeta": {
95-
"@angular/ssr": {
96-
"optional": true
97-
}
98-
},
9990
"jest": {
10091
"testMatch": [
10192
"**/test/**/*.js"

src/common-engine.d.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1 @@
1-
// import { CommonEngine } from '@angular/ssr/node'
2-
3-
// ideally figure out how to use the real CommonEngine type from the Angular package
4-
// as currently it causes following error (due to repo setup?)
5-
// ✘ [ERROR] TS2345: Argument of type 'import("/Users/misiek/dev/angular-runtime/tests/fixtures/angular-19-common-engine/node_modules/@angular/ssr/node/index").CommonEngine' is not assignable to parameter of type 'import("/Users/misiek/dev/angular-runtime/node_modules/@angular/ssr/node/index").CommonEngine'.
6-
// Types have separate declarations of a private property 'options'. [plugin angular-compiler]
7-
export declare function render(commonEngine: any): Promise<Response>
1+
export declare function render(commonEngine: unknown): Promise<Response>

tests/integration.test.mjs

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
/* eslint-disable no-underscore-dangle */
21
import assert from 'node:assert'
3-
import { Module } from 'node:module'
42
import { join } from 'node:path'
53
import { join as posixJoin } from 'node:path/posix'
6-
import { test, describe, before, after } from 'node:test'
4+
import { test, describe } from 'node:test'
75
import { fileURLToPath } from 'node:url'
86

97
import build from '@netlify/build'
@@ -98,21 +96,6 @@ test('Angular 19 using App Engine (Developer Preview)', async () => {
9896
})
9997

10098
describe('Angular version validation', () => {
101-
let originalNodeModulePaths
102-
before(() => {
103-
// Node.js automatically add all parent dirs to lookups, so this test will find @angular/core from main project dev dependencies
104-
// even if test fixture itself doesn't contain it.
105-
106-
// to workaround this we just allow lookup in test fixture dir inspired by https://stackoverflow.com/questions/32455431/prevent-require-from-looking-up-modules-in-the-parent-directory
107-
108-
originalNodeModulePaths = Module._nodeModulePaths
109-
Module._nodeModulePaths = (...args) => originalNodeModulePaths.apply(Module, args).slice(0, 1)
110-
})
111-
112-
after(() => {
113-
Module._nodeModulePaths = originalNodeModulePaths
114-
})
115-
11699
test('checks version for angular 19', async () => {
117100
const result = validateAngularVersion(
118101
await getAngularVersion(fileURLToPath(new URL('fixtures/angular-19-common-engine', import.meta.url))),
@@ -141,4 +124,3 @@ describe('Angular version validation', () => {
141124
assert.strictEqual(result, false)
142125
})
143126
})
144-
/* eslint-enable no-underscore-dangle */

0 commit comments

Comments
 (0)