Fix missing lock acquisition in pool (#953)

Fix some functions in the pool manipulating the routing information without
holding the right lock.

Author: robsdedude

neo4j/io/__init__.py

@@ -1334,19 +1334,21 @@ def deactivate(self, address):
         log.debug("[#0000]  C: <ROUTING> Deactivating address %r", address)
         # We use `discard` instead of `remove` here since the former
         # will not fail if the address has already been removed.
-        for database in self.routing_tables.keys():
-            self.routing_tables[database].routers.discard(address)
-            self.routing_tables[database].readers.discard(address)
-            self.routing_tables[database].writers.discard(address)
+        with self.refresh_lock:
+            for database in self.routing_tables.keys():
+                self.routing_tables[database].routers.discard(address)
+                self.routing_tables[database].readers.discard(address)
+                self.routing_tables[database].writers.discard(address)
         log.debug("[#0000]  C: <ROUTING> table=%r", self.routing_tables)
         super(Neo4jPool, self).deactivate(address)
 
     def on_write_failure(self, address):
         """ Remove a writer address from the routing table, if present.
         """
         log.debug("[#0000]  C: <ROUTING> Removing writer %r", address)
-        for database in self.routing_tables.keys():
-            self.routing_tables[database].writers.discard(address)
+        with self.refresh_lock:
+            for database in self.routing_tables.keys():
+                self.routing_tables[database].writers.discard(address)
         log.debug("[#0000]  C: <ROUTING> table=%r", self.routing_tables)