session_connection_timeout should be inf by default

Author: robsdedude

neo4j/conf.py

@@ -264,7 +264,7 @@ class WorkspaceConfig(Config):
     """
 
     #: Session Connection Timeout
-    session_connection_timeout = 120.0  # seconds
+    session_connection_timeout = float("inf")  # seconds
     # The maximum amount of time to wait for a session to obtain a usable
     # read/write connection. This includes everything necessary for this to
     # happen. Including fetching routing tables, opening sockets, etc.

neo4j/io/__init__.py

@@ -978,7 +978,7 @@ def __repr__(self):
     @contextmanager
     def _refresh_lock_deadline(self, deadline):
         timeout = deadline.to_timeout()
-        if timeout == float("inf"):
+        if timeout is None:
             timeout = -1
         if not self.refresh_lock.acquire(timeout=timeout):
             raise ClientError(

tests/unit/test_conf.py

@@ -56,7 +56,7 @@
 }
 
 test_session_config = {
-    "session_connection_timeout": float("inf"),
+    "session_connection_timeout": 180.0,
     "connection_acquisition_timeout": 60.0,
     "max_transaction_retry_time": 30.0,
     "initial_retry_delay": 1.0,