From 8696b2a5bac83247430ef5003534cd1322cdf911 Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Wed, 7 Sep 2022 11:34:36 +0200 Subject: [PATCH 1/2] Fix temporal it tests New UTC zoned date time has timeZoneOffsetInSeconds values. --- packages/neo4j-driver/test/temporal-types.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/neo4j-driver/test/temporal-types.test.js b/packages/neo4j-driver/test/temporal-types.test.js index 9ee7d2653..5cdbc1393 100644 --- a/packages/neo4j-driver/test/temporal-types.test.js +++ b/packages/neo4j-driver/test/temporal-types.test.js @@ -1455,6 +1455,11 @@ describe('#integration temporal-types', () => { expect(records.length).toEqual(1) const receivedValue = records[0].get(0) + // Amend test for ignore timeZoneOffsetInSeconds returned by the + // new servers in ZonedDateTime with the utc fix + if (value.timeZoneId != null && receivedValue.timeZoneOffsetSeconds != null) { + receivedValue.timeZoneOffsetInSeconds = undefined + } expect(receivedValue).toEqual(value) } From d09b796426dda1dca5dcc8873b18bc1f27b0bbf7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antonio=20Barc=C3=A9los?= Date: Wed, 7 Sep 2022 13:47:58 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com> --- packages/neo4j-driver/test/temporal-types.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/neo4j-driver/test/temporal-types.test.js b/packages/neo4j-driver/test/temporal-types.test.js index 5cdbc1393..6840fbc39 100644 --- a/packages/neo4j-driver/test/temporal-types.test.js +++ b/packages/neo4j-driver/test/temporal-types.test.js @@ -1455,7 +1455,7 @@ describe('#integration temporal-types', () => { expect(records.length).toEqual(1) const receivedValue = records[0].get(0) - // Amend test for ignore timeZoneOffsetInSeconds returned by the + // Amend test to ignore timeZoneOffsetInSeconds returned by the // new servers in ZonedDateTime with the utc fix if (value.timeZoneId != null && receivedValue.timeZoneOffsetSeconds != null) { receivedValue.timeZoneOffsetInSeconds = undefined