From 4af486882c599dbe9e57f27e7e1bfe15826be57d Mon Sep 17 00:00:00 2001 From: Zachary Raineri Date: Sun, 2 Jan 2022 21:46:30 -0600 Subject: [PATCH 1/2] Added missing JSDOC param name Added param originalVersionString to ServerVersion constructor --- packages/neo4j-driver/src/internal/server-version.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/neo4j-driver/src/internal/server-version.js b/packages/neo4j-driver/src/internal/server-version.js index 7a20aa702..43681b048 100644 --- a/packages/neo4j-driver/src/internal/server-version.js +++ b/packages/neo4j-driver/src/internal/server-version.js @@ -34,7 +34,7 @@ class ServerVersion { * @param {number} major the major version number. * @param {number} minor the minor version number. * @param {number} patch the patch version number. - * @param {string} the original version string + * @param {string} originalVersionString the original version string */ constructor (major, minor, patch, originalVersionString) { this.major = major From df98af47b5f67cc7549d3395958670d334188f97 Mon Sep 17 00:00:00 2001 From: Zachary Raineri Date: Tue, 22 Feb 2022 18:12:04 -0600 Subject: [PATCH 2/2] Edited JSDOC to show optional param originalVersionString in the constructor method of ServerVersion is treated as optional in the codebase (line 71). I updated the JSDOC param to match this. --- packages/neo4j-driver/src/internal/server-version.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/neo4j-driver/src/internal/server-version.js b/packages/neo4j-driver/src/internal/server-version.js index 43681b048..9bc38b469 100644 --- a/packages/neo4j-driver/src/internal/server-version.js +++ b/packages/neo4j-driver/src/internal/server-version.js @@ -34,7 +34,7 @@ class ServerVersion { * @param {number} major the major version number. * @param {number} minor the minor version number. * @param {number} patch the patch version number. - * @param {string} originalVersionString the original version string + * @param {string} [originalVersionString] the original version string */ constructor (major, minor, patch, originalVersionString) { this.major = major