From 54c9a4ec1926da8524e1372eca1493bd68604e04 Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Mon, 6 Dec 2021 16:06:02 +0100 Subject: [PATCH 1/7] Enabling stub tests for browser --- packages/testkit-backend/src/skipped-tests/browser.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index 036029007..908a3f180 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -1,9 +1,5 @@ import skip, { ifStartsWith } from './skip' const skippedTests = [ - skip( - 'Stub Tests not implemented for browser', - ifStartsWith('stub') - ), skip( 'TLS Tests not implemented for browwer', ifStartsWith('tls') From f277d3284f47a7e70ef4e960ea07e80c12a3b07c Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Mon, 6 Dec 2021 17:03:52 +0100 Subject: [PATCH 2/7] Disable tests related to socket timeouts --- packages/testkit-backend/src/skipped-tests/browser.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index 908a3f180..1a0503aab 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -1,5 +1,9 @@ import skip, { ifStartsWith } from './skip' const skippedTests = [ + skip( + 'Browser doesn\'t support socket timeouts', + ifStartsWith('stub.configuration_hints.test_connection_recv_timeout_seconds.TestDirectConnectionRecvTimeout') + ), skip( 'TLS Tests not implemented for browwer', ifStartsWith('tls') From a0f7ac1bbbd85e930ebb2e56c6a2df3ca357b09b Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Mon, 6 Dec 2021 17:40:28 +0100 Subject: [PATCH 3/7] Skipping tests related to websocket take too much time to close the connection --- packages/testkit-backend/src/skipped-tests/browser.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index 1a0503aab..f2d5bc171 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -1,9 +1,13 @@ -import skip, { ifStartsWith } from './skip' +import skip, { ifEndsWith, ifStartsWith } from './skip' const skippedTests = [ skip( 'Browser doesn\'t support socket timeouts', ifStartsWith('stub.configuration_hints.test_connection_recv_timeout_seconds.TestDirectConnectionRecvTimeout') ), + skip( + 'Investigate why websocket is getting too much time to close the connection', + ifEndsWith('test_should_check_multi_db_support') + ), skip( 'TLS Tests not implemented for browwer', ifStartsWith('tls') From 2462329f0bc66193706acfabe7689aba9946486e Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Mon, 6 Dec 2021 19:49:47 +0100 Subject: [PATCH 4/7] Skip ttests --- packages/testkit-backend/src/skipped-tests/browser.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index f2d5bc171..09cdfe1f5 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -1,12 +1,13 @@ -import skip, { ifEndsWith, ifStartsWith } from './skip' +import skip, { ifEndsWith, ifEquals, ifStartsWith } from './skip' const skippedTests = [ skip( 'Browser doesn\'t support socket timeouts', - ifStartsWith('stub.configuration_hints.test_connection_recv_timeout_seconds.TestDirectConnectionRecvTimeout') + ifStartsWith('stub.configuration_hints.test_connection_recv_timeout_seconds') ), skip( 'Investigate why websocket is getting too much time to close the connection', - ifEndsWith('test_should_check_multi_db_support') + ifEndsWith('test_should_check_multi_db_support'), + ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset') ), skip( 'TLS Tests not implemented for browwer', From d2b4a7b6245830cd06f4204473b36dbc8f78b4db Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Fri, 10 Dec 2021 11:50:03 +0100 Subject: [PATCH 5/7] Skip test_impersonation_fails_on_v4x3 since WS took forever to close connection --- packages/testkit-backend/src/skipped-tests/browser.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index 09cdfe1f5..a40da2eba 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -7,7 +7,8 @@ const skippedTests = [ skip( 'Investigate why websocket is getting too much time to close the connection', ifEndsWith('test_should_check_multi_db_support'), - ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset') + ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset'), + ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3') ), skip( 'TLS Tests not implemented for browwer', From 4b928b54a9bf403d0362179220a9101f91727a14 Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Fri, 10 Dec 2021 12:39:11 +0100 Subject: [PATCH 6/7] Skipping since it fails with timeout --- packages/testkit-backend/src/skipped-tests/browser.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index a40da2eba..6009ba172 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -8,7 +8,9 @@ const skippedTests = [ 'Investigate why websocket is getting too much time to close the connection', ifEndsWith('test_should_check_multi_db_support'), ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset'), - ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3') + ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3'), + ifEquals('stub.session_run_parameters.test_session_run_parameters.TestSessionRunParameters.test_impersonation_fails_on_v4x3'), + ), skip( 'TLS Tests not implemented for browwer', From 0e647785499b5510ab3abcae5c85ac8be32d0e3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antonio=20Barc=C3=A9los?= Date: Fri, 10 Dec 2021 11:21:56 -0300 Subject: [PATCH 7/7] Apply suggestions from code review Co-authored-by: Robsdedude --- packages/testkit-backend/src/skipped-tests/browser.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/testkit-backend/src/skipped-tests/browser.js b/packages/testkit-backend/src/skipped-tests/browser.js index 6009ba172..aea068c07 100644 --- a/packages/testkit-backend/src/skipped-tests/browser.js +++ b/packages/testkit-backend/src/skipped-tests/browser.js @@ -1,11 +1,11 @@ import skip, { ifEndsWith, ifEquals, ifStartsWith } from './skip' const skippedTests = [ skip( - 'Browser doesn\'t support socket timeouts', + "Browser doesn't support socket timeouts", ifStartsWith('stub.configuration_hints.test_connection_recv_timeout_seconds') ), skip( - 'Investigate why websocket is getting too much time to close the connection', + 'Investigate why websocket is taking too much time to close the connection', ifEndsWith('test_should_check_multi_db_support'), ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset'), ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3'),