From da140a0c8a5e6f44e00dc1e672dc70d66df557e3 Mon Sep 17 00:00:00 2001 From: Robsdedude Date: Thu, 26 Sep 2024 08:34:15 +0200 Subject: [PATCH 1/3] TestKit: add NumberIsNumber feature flag This implementation detail flag signals that the driver is not (fully) capable of differentiating integer and floating point types. --- packages/testkit-backend/src/feature/common.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/testkit-backend/src/feature/common.js b/packages/testkit-backend/src/feature/common.js index 756bcc92a..ac0bb266d 100644 --- a/packages/testkit-backend/src/feature/common.js +++ b/packages/testkit-backend/src/feature/common.js @@ -44,7 +44,8 @@ const features = [ 'Optimization:ImplicitDefaultArguments', 'Optimization:MinimalBookmarksSet', 'Optimization:MinimalResets', - 'Optimization:AuthPipelining' + 'Optimization:AuthPipelining', + 'Detail:NumberIsNumber' ] export default features From 3bcb15e9385acef3825983b3a2980039f29c3481 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Tue, 8 Oct 2024 09:42:59 +0200 Subject: [PATCH 2/3] set testkit to work on the related PR --- testkit/testkit.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testkit/testkit.json b/testkit/testkit.json index 931900356..6f696ccfd 100644 --- a/testkit/testkit.json +++ b/testkit/testkit.json @@ -1,6 +1,6 @@ { "testkit": { "uri": "https://github.com/neo4j-drivers/testkit.git", - "ref": "5.0" + "ref": "number-type-indifference-as-feature-flag" } } From 8c79723635023c3dd4c51aaf96e9f0f24164c158 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Tue, 8 Oct 2024 11:03:23 +0200 Subject: [PATCH 3/3] Update testkit.json --- testkit/testkit.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testkit/testkit.json b/testkit/testkit.json index 6f696ccfd..931900356 100644 --- a/testkit/testkit.json +++ b/testkit/testkit.json @@ -1,6 +1,6 @@ { "testkit": { "uri": "https://github.com/neo4j-drivers/testkit.git", - "ref": "number-type-indifference-as-feature-flag" + "ref": "5.0" } }