From 24c69ac8fb2915872eff67520a915aa9f32c3158 Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Fri, 25 Nov 2022 09:35:31 +0100 Subject: [PATCH 1/3] Clarify usage of USE clause along with SessionConfig#database --- packages/core/src/driver.ts | 3 +++ packages/neo4j-driver-deno/lib/core/driver.ts | 3 +++ 2 files changed, 6 insertions(+) diff --git a/packages/core/src/driver.ts b/packages/core/src/driver.ts index 8de1de9b2..8c30c6e88 100644 --- a/packages/core/src/driver.ts +++ b/packages/core/src/driver.ts @@ -138,6 +138,9 @@ class SessionConfig { * straightforward way and potentially simplifies driver logic as well as * reduces network communication resulting in better performance. * + * Usage of Cypher clauses like USE is not a replacement for this option. + * Driver sends Cypher to the server for processing. + * * When no explicit name is set, the driver behavior depends on the connection * URI scheme supplied to the driver on instantiation and Bolt protocol * version. diff --git a/packages/neo4j-driver-deno/lib/core/driver.ts b/packages/neo4j-driver-deno/lib/core/driver.ts index b7850ddd8..a8de58598 100644 --- a/packages/neo4j-driver-deno/lib/core/driver.ts +++ b/packages/neo4j-driver-deno/lib/core/driver.ts @@ -138,6 +138,9 @@ class SessionConfig { * straightforward way and potentially simplifies driver logic as well as * reduces network communication resulting in better performance. * + * Usage of Cypher clauses like USE is not a replacement for this option. + * Driver sends Cypher to the server for processing. + * * When no explicit name is set, the driver behavior depends on the connection * URI scheme supplied to the driver on instantiation and Bolt protocol * version. From 9bd8b48c76aebcbf37fdc0d2641130eb71c6ae74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antonio=20Barc=C3=A9los?= Date: Fri, 25 Nov 2022 12:15:48 +0100 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Robsdedude --- packages/core/src/driver.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/driver.ts b/packages/core/src/driver.ts index 8c30c6e88..04c1fe8c2 100644 --- a/packages/core/src/driver.ts +++ b/packages/core/src/driver.ts @@ -139,7 +139,7 @@ class SessionConfig { * reduces network communication resulting in better performance. * * Usage of Cypher clauses like USE is not a replacement for this option. - * Driver sends Cypher to the server for processing. + * The driver does not parse any Cypher. * * When no explicit name is set, the driver behavior depends on the connection * URI scheme supplied to the driver on instantiation and Bolt protocol From 8f31b14fb2f0c311d88cf6405c36487d07950aac Mon Sep 17 00:00:00 2001 From: Antonio Barcelos Date: Fri, 25 Nov 2022 12:17:10 +0100 Subject: [PATCH 3/3] Apply suggestions to DenoJS --- packages/neo4j-driver-deno/lib/core/driver.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/neo4j-driver-deno/lib/core/driver.ts b/packages/neo4j-driver-deno/lib/core/driver.ts index a8de58598..9d8027f85 100644 --- a/packages/neo4j-driver-deno/lib/core/driver.ts +++ b/packages/neo4j-driver-deno/lib/core/driver.ts @@ -139,7 +139,7 @@ class SessionConfig { * reduces network communication resulting in better performance. * * Usage of Cypher clauses like USE is not a replacement for this option. - * Driver sends Cypher to the server for processing. + * The driver does not parse any Cypher. * * When no explicit name is set, the driver behavior depends on the connection * URI scheme supplied to the driver on instantiation and Bolt protocol