Make transaction commit and rollback return standard promises

Author: ali-ince

src/transaction.js

@@ -107,7 +107,12 @@ class Transaction {
     this._state = committed.state
     // clean up
     this._onClose()
-    return committed.result
+    return new Promise((resolve, reject) => {
+      committed.result.subscribe({
+        onCompleted: () => resolve(),
+        onError: error => reject(error)
+      })
+    })
   }
 
   /**
@@ -118,15 +123,20 @@ class Transaction {
    * @returns {Result} New Result
    */
   rollback () {
-    let committed = this._state.rollback({
+    let rolledback = this._state.rollback({
       connectionHolder: this._connectionHolder,
       onError: this._onError,
       onComplete: this._onComplete
     })
-    this._state = committed.state
+    this._state = rolledback.state
     // clean up
     this._onClose()
-    return committed.result
+    return new Promise((resolve, reject) => {
+      rolledback.result.subscribe({
+        onCompleted: () => resolve(),
+        onError: error => reject(error)
+      })
+    })
   }
 
   /**

test/transaction.test.js

@@ -19,6 +19,7 @@
 import neo4j from '../src'
 import sharedNeo4j from './internal/shared-neo4j'
 import { ServerVersion } from '../src/internal/server-version'
+import TxConfig from '../src/internal/tx-config'
 
 describe('#integration transaction', () => {
   let driver
@@ -571,6 +572,20 @@ describe('#integration transaction', () => {
       })
   })
 
+  it('should return empty promise on commit', async () => {
+    const tx = session.beginTransaction()
+    const result = await tx.commit()
+
+    expect(result).toBeUndefined()
+  })
+
+  it('should return empty promise on rollback', async () => {
+    const tx = session.beginTransaction()
+    const result = await tx.rollback()
+
+    expect(result).toBeUndefined()
+  })
+
   function expectSyntaxError (error) {
     expect(error.code).toBe('Neo.ClientError.Statement.SyntaxError')
   }