Skip to content

Commit ce80d1f

Browse files
Improve Observer types inline docs (#1066)
Co-authored-by: Antonio Barcélos <antonio.barcelos@neo4j.com>
1 parent 1364002 commit ce80d1f

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

packages/core/src/internal/observers.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ import ResultSummary from '../result-summary'
2323
interface StreamObserver {
2424
/**
2525
* Will be called on every record that comes in and transform a raw record
26-
* to a Object. If user-provided observer is present, pass transformed record
27-
* to it's onNext method, otherwise, push to record que.
26+
* to an Object. If user-provided observer is present, pass transformed record
27+
* to its onNext method; otherwise push to record que.
2828
* @param {Array} rawRecord - An array with the raw record
2929
*/
3030
onNext?: (rawRecord: any[]) => void
3131
/**
3232
* Will be called on errors.
3333
* If user-provided observer is present, pass the error
34-
* to it's onError method, otherwise set instance variable _error.
34+
* to its onError method, otherwise set instance variable _error.
3535
* @param {Object} error - An error object
3636
*/
3737
onError: (error: Error) => void
@@ -40,7 +40,6 @@ interface StreamObserver {
4040

4141
/**
4242
* Interface to observe updates on the Result which is being produced.
43-
*
4443
*/
4544
interface ResultObserver {
4645
/**
@@ -51,7 +50,7 @@ interface ResultObserver {
5150
onKeys?: (keys: string[]) => void
5251

5352
/**
54-
* Receive the each record present on the {@link @Result}
53+
* Receive each record present on the {@link @Result}
5554
* @param {Record} record The {@link Record} produced
5655
*/
5756
onNext?: (record: Record) => void
@@ -115,7 +114,7 @@ export interface ResultStreamObserver extends StreamObserver {
115114
* @param {Object} observer - Observer object
116115
* @param {function(keys: String[])} observer.onKeys - Handle stream header, field keys.
117116
* @param {function(record: Object)} observer.onNext - Handle records, one by one.
118-
* @param {function(metadata: Object)} observer.onCompleted - Handle stream tail, the metadata.
117+
* @param {function(metadata: Object)} observer.onCompleted - Handle stream tail, the summary.
119118
* @param {function(error: Object)} observer.onError - Handle errors, should always be provided.
120119
*/
121120
subscribe: (observer: ResultObserver) => void

packages/neo4j-driver-deno/lib/core/internal/observers.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ import ResultSummary from '../result-summary.ts'
2323
interface StreamObserver {
2424
/**
2525
* Will be called on every record that comes in and transform a raw record
26-
* to a Object. If user-provided observer is present, pass transformed record
27-
* to it's onNext method, otherwise, push to record que.
26+
* to an Object. If user-provided observer is present, pass transformed record
27+
* to its onNext method; otherwise push to record que.
2828
* @param {Array} rawRecord - An array with the raw record
2929
*/
3030
onNext?: (rawRecord: any[]) => void
3131
/**
3232
* Will be called on errors.
3333
* If user-provided observer is present, pass the error
34-
* to it's onError method, otherwise set instance variable _error.
34+
* to its onError method, otherwise set instance variable _error.
3535
* @param {Object} error - An error object
3636
*/
3737
onError: (error: Error) => void
@@ -40,7 +40,6 @@ interface StreamObserver {
4040

4141
/**
4242
* Interface to observe updates on the Result which is being produced.
43-
*
4443
*/
4544
interface ResultObserver {
4645
/**
@@ -51,7 +50,7 @@ interface ResultObserver {
5150
onKeys?: (keys: string[]) => void
5251

5352
/**
54-
* Receive the each record present on the {@link @Result}
53+
* Receive each record present on the {@link @Result}
5554
* @param {Record} record The {@link Record} produced
5655
*/
5756
onNext?: (record: Record) => void
@@ -115,7 +114,7 @@ export interface ResultStreamObserver extends StreamObserver {
115114
* @param {Object} observer - Observer object
116115
* @param {function(keys: String[])} observer.onKeys - Handle stream header, field keys.
117116
* @param {function(record: Object)} observer.onNext - Handle records, one by one.
118-
* @param {function(metadata: Object)} observer.onCompleted - Handle stream tail, the metadata.
117+
* @param {function(metadata: Object)} observer.onCompleted - Handle stream tail, the summary.
119118
* @param {function(error: Object)} observer.onError - Handle errors, should always be provided.
120119
*/
121120
subscribe: (observer: ResultObserver) => void

0 commit comments

Comments
 (0)