Add RxManagedTransaction and deprecate commit, rollback and close

Author: bigmontz

packages/neo4j-driver/src/session-rx.js

@@ -21,6 +21,7 @@ import { flatMap, catchError, concat } from 'rxjs/operators'
 import RxResult from './result-rx'
 import { Session, internal } from 'neo4j-driver-core'
 import RxTransaction from './transaction-rx'
+import RxManagedTransaction from './transaction-managed-rx'
 import RxRetryLogic from './internal/retry-logic-rx'
 
 const {
@@ -84,7 +85,7 @@ export default class RxSession {
    * Executes the provided unit of work in a {@link READ} reactive transaction which is created with the provided
    * transaction configuration.
    * @public
-   * @param {function(txc: RxTransaction): Observable} work - A unit of work to be executed.
+   * @param {function(txc: RxManagedTransaction): Observable} work - A unit of work to be executed.
    * @param {TransactionConfig} transactionConfig - Configuration for the enclosing transaction created by the driver.
    * @returns {Observable} - A reactive stream returned by the unit of work.
    */
@@ -96,7 +97,7 @@ export default class RxSession {
    * Executes the provided unit of work in a {@link WRITE} reactive transaction which is created with the provided
    * transaction configuration.
    * @public
-   * @param {function(txc: RxTransaction): Observable} work - A unit of work to be executed.
+   * @param {function(txc: RxManagedTransaction): Observable} work - A unit of work to be executed.
    * @param {TransactionConfig} transactionConfig - Configuration for the enclosing transaction created by the driver.
    * @returns {Observable} - A reactive stream returned by the unit of work.
    */

packages/neo4j-driver/test/types/session-rx.test.ts

@@ -28,6 +28,7 @@ import {
 } from 'neo4j-driver-core'
 import { Observable, of, Observer, throwError } from 'rxjs'
 import { concat, finalize, catchError } from 'rxjs/operators'
+import RxManagedTransaction from '../../types/transaction-managed-rx'
 
 const dummy: any = null
 const intValue: Integer = Integer.fromInt(42)
@@ -152,3 +153,15 @@ const observable6: Observable<number> = rxSession.writeTransaction(
   (tx: RxTransaction) => of(42),
   txConfig4
 )
+
+const observable7: Observable<string> = rxSession.readTransaction(
+  (tx: RxManagedTransaction) => {
+    return of('42')
+  }
+)
+
+const observable8: Observable<string> = rxSession.writeTransaction(
+  (tx: RxManagedTransaction) => {
+    return of('42')
+  }
+)

packages/neo4j-driver/types/index.d.ts

@@ -74,6 +74,7 @@ import {
 } from './driver'
 import RxSession from './session-rx'
 import RxTransaction from './transaction-rx'
+import RxManagedTransaction from './transaction-managed-rx'
 import RxResult from './result-rx'
 import { Parameters } from './query-runner'
 
@@ -118,6 +119,7 @@ declare const types: {
   Integer: typeof Integer
   RxSession: RxSession
   RxTransaction: RxTransaction
+  RxManagedTransaction: RxManagedTransaction
   RxResult: RxResult
 }
 
@@ -203,6 +205,7 @@ declare const forExport: {
   DateTime: DateTime
   RxSession: RxSession
   RxTransaction: RxTransaction
+  RxManagedTransaction: RxManagedTransaction
   RxResult: RxResult
   ConnectionProvider: ConnectionProvider
   isDuration: typeof isDuration
@@ -262,6 +265,7 @@ export {
   DateTime,
   RxSession,
   RxTransaction,
+  RxManagedTransaction,
   RxResult,
   ConnectionProvider,
   isDuration,

packages/neo4j-driver/types/session-rx.d.ts

@@ -18,11 +18,12 @@
  */
 import RxResult from './result-rx'
 import RxTransaction from './transaction-rx'
+import RxManagedTransaction from './transaction-managed-rx'
 import { TransactionConfig } from 'neo4j-driver-core'
 import { Parameters } from './query-runner'
 import { Observable } from 'rxjs'
 
-declare type RxTransactionWork<T> = (tx: RxTransaction) => Observable<T>
+declare type RxTransactionWork<T> = (tx: RxManagedTransaction) => Observable<T>
 
 declare interface RxSession {
   run(