Skip to content

Commit c54329a

Browse files
authored
Add temporary feature flags which doesn't need change driver or testkit code (#856)
The feature flags are: * 'Temporary:CypherPathAndRelationship' * 'Temporary:DriverFetchSize' * 'Temporary:DriverMaxTxRetryTime' * 'Temporary:GetConnectionPoolMetrics'
1 parent 32ec3b2 commit c54329a

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

packages/testkit-backend/src/request-handlers.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ export function NewDriver (context, data, wire) {
7979
if ('connectionAcquisitionTimeoutMs' in data) {
8080
config.connectionAcquisitionTimeout = data.connectionAcquisitionTimeoutMs
8181
}
82+
if ('fetchSize' in data) {
83+
config.fetchSize = data.fetchSize
84+
}
8285
let driver
8386
try {
8487
driver = neo4j.driver(uri, parsedAuthToken, config)
@@ -368,6 +371,10 @@ export function GetFeatures (_context, _params, wire) {
368371
'Feature:API:Result.Peek',
369372
'Temporary:ConnectionAcquisitionTimeout',
370373
'Temporary:TransactionClose',
374+
'Temporary:CypherPathAndRelationship',
375+
'Temporary:DriverFetchSize',
376+
'Temporary:DriverMaxTxRetryTime',
377+
'Temporary:GetConnectionPoolMetrics',
371378
...SUPPORTED_TLS
372379
]
373380
})

packages/testkit-backend/src/skipped-tests/browser.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const skippedTests = [
1010
ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset'),
1111
ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3'),
1212
ifEquals('stub.session_run_parameters.test_session_run_parameters.TestSessionRunParameters.test_impersonation_fails_on_v4x3'),
13-
1413
),
1514
skip(
1615
'TLS Tests not implemented for browwer',

packages/testkit-backend/src/skipped-tests/common.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import skip, { ifEquals, ifEndsWith, ifStartsWith } from './skip'
22

33
const skippedTests = [
4+
skip(
5+
'Flaky in TeamCity',
6+
ifEndsWith('test_should_fail_when_writing_to_unexpectedly_interrupting_writers_on_run_using_tx_function'),
7+
),
48
skip(
59
'Partial session iteration is not supported by the js driver',
610
ifEquals('neo4j.sessionrun.TestSessionRun.test_partial_iteration'),

0 commit comments

Comments
 (0)