browser bolt agent test

Author: ConorNeo

packages/core/src/internal/bolt-agent/browser/bolt-agent.ts

@@ -17,9 +17,10 @@
 * limitations under the License.
 */
 /* eslint-disable */
-export function fromVersion (version: string): string {
+// @ts-ignore: browser code so must be skipped by ts
+export function fromVersion (version: string, windowProvider = () => window): string {
   // @ts-ignore: browser code so must be skipped by ts
-  const APP_VERSION = window.navigator.appVersion
+  const APP_VERSION = windowProvider().navigator.appVersion
 
   //APP_VERSION looks like 5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36
   const OS = APP_VERSION.split("(")[1].split(")")[0];

packages/core/src/internal/bolt-agent/deno/bolt-agent.ts

@@ -19,9 +19,13 @@
 
 /* eslint-disable */
 export function fromVersion (version: string): string {
+  //@ts-ignore
   const HOST_ARCH = Deno.build.arch
+  //@ts-ignore
   const DENO_VERSION = `Deno/${Deno.version.deno}`
+  //@ts-ignore
   const NODE_V8_VERSION = Deno.version.v8
+  //@ts-ignore
   const OS_NAME_VERSION = `${Deno.build.os} ${Deno.osRelease}`
 
   return `neo4j-javascript/${version} (${OS_NAME_VERSION}; ${HOST_ARCH}) ${DENO_VERSION} (v8 ${NODE_V8_VERSION})`

packages/core/test/internal/bolt-agent/browser/bolt-agent.test.ts

@@ -0,0 +1,38 @@
+/**
+ * Copyright (c) "Neo4j"
+ * Neo4j Sweden AB [http://neo4j.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { fromVersion } from '../../../../src/internal/bolt-agent/browser'
+
+describe('#unit boltAgent', () => {
+  // This test is very fragile but the exact look of this string should not change without PM approval
+  it('should return the correct bolt agent for specified version', () => {
+    const version = '5.3'
+    const windowProvider = (): any => {
+      return {
+        navigator: {
+          appVersion: '5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36'
+        }
+      }
+    }
+
+    const boltAgent = fromVersion(version, windowProvider)
+
+    expect(boltAgent.length === 0).toBeFalsy()
+    expect(boltAgent).toEqual(`neo4j-javascript/${version} (Macintosh; Intel Mac OS X 10_15_7)`)
+  })
+})

packages/core/test/internal/bolt-agent/node/bolt-agent.test.ts

@@ -29,7 +29,7 @@ describe('#unit boltAgent', () => {
     const NODE_VERSION = 'Node/' + process.versions.node
     const NODE_V8_VERSION = process.versions.v8
 
-    const osName = BoltAgent.mapOs(os.platform())
+    const osName = os.platform()
 
     expect(boltAgent.length === 0).toBeFalsy()
     expect(boltAgent).toContain(`neo4j-javascript/${version}`)