Remove isOpen method from managed transactions

Author: bigmontz

packages/core/src/session.ts

@@ -449,7 +449,6 @@ class Session {
       () => this._beginTransaction(accessMode, transactionConfig),
       transactionWork,
       tx => new ManagedTransaction({
-        isOpen: tx.isOpen.bind(tx),
         run: tx.run.bind(tx),
       })
     )

packages/core/src/transaction-managed.ts

@@ -24,28 +24,19 @@ interface Run {
   (query: Query, parameters?: any): Result
 }
 
-interface IsOpen {
-  (): boolean
-}
-
 /**
  * Represents a transaction that is managed by the transaction executor.
  * 
  * @public
  */
 class ManagedTransaction {
   private _run: Run
-  private _isOpen: IsOpen
 
-  constructor({ run, isOpen }: { run: Run, isOpen: IsOpen }) {
+  constructor({ run }: { run: Run }) {
     /**
      * @private
      */
     this._run = run
-    /**
-     * @private
-     */
-    this._isOpen = isOpen
   }
 
   /**
@@ -59,14 +50,6 @@ class ManagedTransaction {
   run(query: Query, parameters?: any): Result {
     return this._run(query, parameters)
   }
-
-  /**
-  * Check if this transaction is active, which means commit and rollback did not happen.
-  * @return {boolean} `true` when not committed and not rolled back, `false` otherwise.
-  */
-  isOpen(): boolean {
-    return this._isOpen()
-  }
 }
 
 export default ManagedTransaction

packages/core/test/session.test.ts

@@ -317,22 +317,6 @@ describe('session', () => {
       expect(status.functionCalled).toEqual(true)
       expect(run).toHaveBeenCalledWith(query, params)
     })
-
-    it('should proxy isOpen to the begun transaction', async () => {
-      const connection = mockBeginWithSuccess(newFakeConnection())
-      const session = newSessionWithConnection(connection, false, FETCH_ALL)
-      const isOpen = jest.spyOn(Transaction.prototype, 'isOpen').mockImplementationOnce(() => true)
-      const status = { functionCalled: false }
-
-      await execute(session)(async (tx: ManagedTransaction) => {
-        status.functionCalled = true
-        expect(tx.isOpen()).toBe(true)
-      })
-
-      expect(status.functionCalled).toEqual(true)
-      expect(isOpen).toHaveBeenCalled()
-    })
-  })
 })
 
 function mockBeginWithSuccess(connection: FakeConnection) {

packages/neo4j-driver/src/session-rx.js

@@ -140,8 +140,7 @@ export default class RxSession {
    */
   _executeInTransaction (accessMode, work, transactionConfig) {
     const wrapper = txc => new RxManagedTransaction({
-      run: txc.run.bind(txc),
-      isOpen: txc.isOpen.bind(txc)
+      run: txc.run.bind(txc)
     })
     return this._runTransaction(accessMode, work, transactionConfig, wrapper)
   }

packages/neo4j-driver/src/transaction-managed-rx.js

@@ -23,9 +23,8 @@
  * @public
  */
 class RxManagedTransaction {
-  constructor({ run, isOpen }) {
+  constructor({ run }) {
     this._run = run
-    this._isOpen = isOpen
   }
 
   /**
@@ -39,14 +38,6 @@ class RxManagedTransaction {
    run (query, parameters) {
      return this._run(query, parameters)
    }
-
-   /**
-   * Check if this transaction is active, which means commit and rollback did not happen.
-   * @return {boolean} `true` when not committed and not rolled back, `false` otherwise.
-   */
-    isOpen() {
-      return this._isOpen()
-    }
 }
 
 export default RxManagedTransaction

packages/neo4j-driver/test/types/transaction-managed-rx.test.ts

@@ -20,8 +20,7 @@
 import RxManagedTransaction from '../../types/transaction-managed-rx'
 import { Record, ResultSummary } from 'neo4j-driver-core'
 import RxResult from '../../types/result-rx'
-import { Observable, of, Observer, throwError } from 'rxjs'
-import { concat, finalize, catchError } from 'rxjs/operators'
+import { Observer } from 'rxjs'
 
 const dummy: any = null
 
@@ -60,5 +59,3 @@ const result2: RxResult = tx.run('RETURN $value', { value: '42' })
 result2.keys().subscribe(keysObserver)
 result2.records().subscribe(recordsObserver)
 result2.consume().subscribe(summaryObserver)
-
-const isOpen: boolean = tx.isOpen()

packages/neo4j-driver/types/transaction-managed-rx.d.ts

@@ -21,7 +21,6 @@
 
  declare interface RxManagedTransaction {
    run(query: string, parameters?: Parameters): RxResult
-   isOpen(): boolean
  }
 
  export default RxManagedTransaction