Exposed onComplete method from Driver.

Provides quick feedback to client that credentials are correct.

Author: eve-bright

lib/browser/neo4j-web.js

@@ -213,6 +213,13 @@ var _ConnectionStreamObserver = (function (_StreamObserver) {
         this._hasFailed = true;
       }
     }
+  }, {
+    key: 'onCompleted',
+    value: function onCompleted(message) {
+      if (this._driver.onCompleted) {
+        this._driver.onCompleted(message);
+      }
+    }
   }]);
 
   return _ConnectionStreamObserver;

lib/browser/neo4j-web.min.js

@@ -62,16 +62,35 @@ function userHome() {
   return process.env[process.platform == 'win32' ? 'USERPROFILE' : 'HOME'];
 }
 
+function mkFullPath(pathToCreate) {
+  try {
+    _fs2['default'].mkdirSync(pathToCreate);
+  } catch (e) {
+    if (e.code === 'ENOENT') {
+      // Create parent dir
+      mkFullPath(_path2['default'].dirname(pathToCreate));
+      // And now try again
+      mkFullPath(pathToCreate);
+      return;
+    }
+    if (e.code === 'EEXIST') {
+      return;
+    }
+    throw e;
+  }
+}
+
 function loadFingerprint(serverId, knownHostsPath, cb) {
-  if (!_fs2['default'].existsSync(knownHostsPath)) {
-    cb(null);
-    return;
+  try {
+    _fs2['default'].accessSync(knownHostsPath);
+  } catch (e) {
+    return cb(null);
   }
   var found = false;
   require('readline').createInterface({
     input: _fs2['default'].createReadStream(knownHostsPath)
   }).on('line', function (line) {
-    if (line.startsWith(serverId)) {
+    if (!found && line.startsWith(serverId)) {
       found = true;
       cb(line.split(" ")[1]);
     }
@@ -82,11 +101,31 @@ function loadFingerprint(serverId, knownHostsPath, cb) {
   });
 }
 
-function storeFingerprint(serverId, knownHostsPath, fingerprint) {
+var _lockFingerprintFromAppending = {};
+function storeFingerprint(serverId, knownHostsPath, fingerprint, cb) {
+  // we check if the serverId has been appended
+  if (!!_lockFingerprintFromAppending[serverId]) {
+    // if it has, we ignore it
+    return cb(null);
+  }
+
+  // we make the line as appended
+  // ( 1 is more efficient to store than true because true is an oddball )
+  _lockFingerprintFromAppending[serverId] = 1;
+
+  // If file doesn't exist, create full path to it
+  try {
+    _fs2['default'].accessSync(knownHostsPath);
+  } catch (_) {
+    mkFullPath(_path2['default'].dirname(knownHostsPath));
+  }
+
   _fs2['default'].appendFile(knownHostsPath, serverId + " " + fingerprint + _os.EOL, "utf8", function (err) {
+    delete _lockFingerprintFromAppending[serverId];
     if (err) {
       console.log(err);
     }
+    return cb(err);
   });
 }
 
@@ -140,8 +179,12 @@ var TrustStrategy = {
         if (knownFingerprint === serverFingerprint) {
           onSuccess();
         } else if (knownFingerprint == null) {
-          storeFingerprint(serverId, knownHostsPath, serverFingerprint);
-          onSuccess();
+          storeFingerprint(serverId, knownHostsPath, serverFingerprint, function (err) {
+            if (err) {
+              return onFailure(err);
+            }
+            return onSuccess();
+          });
         } else {
           onFailure((0, _error.newError)("Database encryption certificate has changed, and no longer " + "matches the certificate stored for " + serverId + " in `" + knownHostsPath + "`. As a security precaution, this driver will not automatically trust the new " + "certificate, because doing so would allow an attacker to pretend to be the Neo4j " + "instance we want to connect to. The certificate provided by the server looks like: " + serverCert + ". If you trust that this certificate is valid, simply remove the line " + "starting with " + serverId + " in `" + knownHostsPath + "`, and the driver will " + "update the file with the new certificate. You can configure which file the driver " + "should use to store this information by setting `knownHosts` to another path in " + "your driver configuration - and you can disable encryption there as well using " + "`encrypted:false`."));
         }

lib/browser/neo4j-web.test.js

@@ -193,6 +193,7 @@ var _mappers = {
  */
 
 var Connection = (function () {
+
   /**
    * @constructor
    * @param channel - channel with a 'write' function and a 'onmessage'
@@ -370,42 +371,61 @@ var Connection = (function () {
   }, {
     key: "initialize",
     value: function initialize(clientName, token, observer) {
+      var _this2 = this;
+
       this._queueObserver(observer);
-      this._packer.packStruct(INIT, [clientName, token]);
+      this._packer.packStruct(INIT, [this._packable(clientName), this._packable(token)], function (err) {
+        return _this2._handleFatalError(err);
+      });
       this._chunker.messageBoundary();
+      this.sync();
     }
 
     /** Queue a RUN-message to be sent to the database */
   }, {
     key: "run",
     value: function run(statement, params, observer) {
+      var _this3 = this;
+
       this._queueObserver(observer);
-      this._packer.packStruct(RUN, [statement, params]);
+      this._packer.packStruct(RUN, [this._packable(statement), this._packable(params)], function (err) {
+        return _this3._handleFatalError(err);
+      });
       this._chunker.messageBoundary();
     }
 
     /** Queue a PULL_ALL-message to be sent to the database */
   }, {
     key: "pullAll",
     value: function pullAll(observer) {
+      var _this4 = this;
+
       this._queueObserver(observer);
-      this._packer.packStruct(PULL_ALL);
+      this._packer.packStruct(PULL_ALL, [], function (err) {
+        return _this4._handleFatalError(err);
+      });
       this._chunker.messageBoundary();
     }
 
     /** Queue a DISCARD_ALL-message to be sent to the database */
   }, {
     key: "discardAll",
     value: function discardAll(observer) {
+      var _this5 = this;
+
       this._queueObserver(observer);
-      this._packer.packStruct(DISCARD_ALL);
+      this._packer.packStruct(DISCARD_ALL, [], function (err) {
+        return _this5._handleFatalError(err);
+      });
       this._chunker.messageBoundary();
     }
 
     /** Queue a RESET-message to be sent to the database */
   }, {
     key: "reset",
     value: function reset(observer) {
+      var _this6 = this;
+
       this._isHandlingFailure = true;
       var self = this;
       var wrappedObs = {
@@ -419,16 +439,22 @@ var Connection = (function () {
         }
       };
       this._queueObserver(wrappedObs);
-      this._packer.packStruct(RESET);
+      this._packer.packStruct(RESET, [], function (err) {
+        return _this6._handleFatalError(err);
+      });
       this._chunker.messageBoundary();
     }
 
     /** Queue a ACK_FAILURE-message to be sent to the database */
   }, {
     key: "_ackFailure",
     value: function _ackFailure(observer) {
+      var _this7 = this;
+
       this._queueObserver(observer);
-      this._packer.packStruct(ACK_FAILURE);
+      this._packer.packStruct(ACK_FAILURE, [], function (err) {
+        return _this7._handleFatalError(err);
+      });
       this._chunker.messageBoundary();
     }
   }, {
@@ -477,6 +503,15 @@ var Connection = (function () {
     value: function close(cb) {
       this._ch.close(cb);
     }
+  }, {
+    key: "_packable",
+    value: function _packable(value) {
+      var _this8 = this;
+
+      return this._packer.packable(value, function (err) {
+        return _this8._handleFatalError(err);
+      });
+    }
   }]);
 
   return Connection;