remove useVectorTypes

Author: MaxAake

packages/bolt-connection/src/bolt/bolt-protocol-v1.js

@@ -68,29 +68,28 @@ export default class BoltProtocol {
    * @param {Object} packstreamConfig Packstream configuration
    * @param {boolean} packstreamConfig.disableLosslessIntegers if this connection should convert all received integers to native JS numbers.
    * @param {boolean} packstreamConfig.useBigInt if this connection should convert all received integers to native BigInt numbers.
-   * @param {boolean} packstreamConfig.useVectorTypes if this connection should support vector types and treat TypedArras as vectors.
    * @param {CreateResponseHandler} createResponseHandler Function which creates the response handler
    * @param {Logger} log the logger
    * @param {OnProtocolError} onProtocolError handles protocol errors
    */
   constructor (
     server,
     chunker,
-    { disableLosslessIntegers, useBigInt, useVectorTypes } = {},
+    { disableLosslessIntegers, useBigInt } = {},
     createResponseHandler = () => null,
     log,
     onProtocolError
   ) {
     this._server = server || {}
     this._chunker = chunker
-    this._packer = this._createPacker(chunker, useVectorTypes)
-    this._unpacker = this._createUnpacker(disableLosslessIntegers, useBigInt, useVectorTypes)
+    this._packer = this._createPacker(chunker)
+    this._unpacker = this._createUnpacker(disableLosslessIntegers, useBigInt)
     this._responseHandler = createResponseHandler(this)
     this._log = log
     this._onProtocolError = onProtocolError
     this._fatalError = null
     this._lastMessageSignature = null
-    this._config = { disableLosslessIntegers, useBigInt, useVectorTypes }
+    this._config = { disableLosslessIntegers, useBigInt }
   }
 
   get transformer () {
@@ -489,8 +488,8 @@ export default class BoltProtocol {
     return new v1.Packer(chunker)
   }
 
-  _createUnpacker (disableLosslessIntegers, useBigInt, useVectorTypes) {
-    return new v1.Unpacker(disableLosslessIntegers, useBigInt, useVectorTypes)
+  _createUnpacker (disableLosslessIntegers, useBigInt) {
+    return new v1.Unpacker(disableLosslessIntegers, useBigInt)
   }
 
   /**

packages/bolt-connection/src/bolt/bolt-protocol-v2.js

@@ -29,8 +29,8 @@ export default class BoltProtocol extends BoltProtocolV1 {
     return new v2.Packer(chunker)
   }
 
-  _createUnpacker (disableLosslessIntegers, useBigInt, useVectorTypes) {
-    return new v2.Unpacker(disableLosslessIntegers, useBigInt, useVectorTypes)
+  _createUnpacker (disableLosslessIntegers, useBigInt) {
+    return new v2.Unpacker(disableLosslessIntegers, useBigInt)
   }
 
   get transformer () {

packages/bolt-connection/src/bolt/create.js

@@ -50,7 +50,6 @@ import ResponseHandler from './response-handler'
  * @param {ResponseHandler~Observer} config.observer Observer
  * @param {boolean} config.disableLosslessIntegers Disable the lossless integers
  * @param {boolean} packstreamConfig.useBigInt if this connection should convert all received integers to native BigInt numbers.
- * @param {boolean} packstreamConfig.useVectorTypes if this connection should support vector types and treat TypedArras as vectors.
  * @param {boolean} config.serversideRouting It's using server side routing
  */
 export default function create ({
@@ -60,7 +59,6 @@ export default function create ({
   channel,
   disableLosslessIntegers,
   useBigInt,
-  useVectorTypes,
   serversideRouting,
   server, // server info
   log,
@@ -96,7 +94,7 @@ export default function create ({
     version,
     server,
     chunker,
-    { disableLosslessIntegers, useBigInt, useVectorTypes },
+    { disableLosslessIntegers, useBigInt },
     serversideRouting,
     createResponseHandler,
     observer.onProtocolError.bind(observer),

packages/bolt-connection/src/connection/connection-channel.js

@@ -69,7 +69,6 @@ export function createChannelConnection (
           dechunker,
           disableLosslessIntegers: config.disableLosslessIntegers,
           useBigInt: config.useBigInt,
-          useVectorTypes: config.useVectorTypes,
           serversideRouting,
           server: conn.server,
           log: conn.logger,

packages/bolt-connection/src/packstream/packstream-v1.js

@@ -324,10 +324,9 @@ class Unpacker {
    * @param {boolean} disableLosslessIntegers if this unpacker should convert all received integers to native JS numbers.
    * @param {boolean} useBigInt if this unpacker should convert all received integers to Bigint
    */
-  constructor (disableLosslessIntegers = false, useBigInt = false, useVectorTypes = true) {
+  constructor (disableLosslessIntegers = false, useBigInt = false) {
     this._disableLosslessIntegers = disableLosslessIntegers
     this._useBigInt = useBigInt
-    this._useVectorTypes = useVectorTypes
   }
 
   unpack (buffer, hydrateStructure = functional.identity) {
@@ -487,11 +486,7 @@ class Unpacker {
     for (let i = 0; i < size; i++) {
       value[i] = buffer.readInt8()
     }
-    if (this._useVectorTypes) {
-      return value.buffer
-    } else {
-      return value
-    }
+    return value
   }
 
   _unpackMap (marker, markerHigh, markerLow, buffer, hydrateStructure) {

packages/bolt-connection/src/packstream/packstream-v2.js

@@ -29,7 +29,7 @@ export class Unpacker extends v1.Unpacker {
    * @param {boolean} disableLosslessIntegers if this unpacker should convert all received integers to native JS numbers.
    * @param {boolean} useBigInt if this unpacker should convert all received integers to Bigint
    */
-  constructor (disableLosslessIntegers = false, useBigInt = false, useVectorTypes = true) {
-    super(disableLosslessIntegers, useBigInt, useVectorTypes)
+  constructor (disableLosslessIntegers = false, useBigInt = false) {
+    super(disableLosslessIntegers, useBigInt)
   }
 }

packages/core/src/types.ts

@@ -77,7 +77,6 @@ export class Config {
   disableLosslessIntegers?: boolean
   notificationFilter?: NotificationFilter
   useBigInt?: boolean
-  useVectorTypes?: boolean
   logging?: LoggingConfig
   resolver?: (address: string) => string[] | Promise<string[]>
   userAgent?: string
@@ -263,18 +262,6 @@ export class Config {
      */
     this.useBigInt = false
 
-    /**
-     * Enables Vector types being sent over bolt, and makes all TypedArrays be interpreted as vectors
-     *
-     * **Warning:** This makes TypedArrays be sent as Vectors rather than Lists, and requires bytes be sent as ArrayBuffers rather than Int8Arrays
-     * If migrating from 5.x drivers and vector types are not needed, this can be disabled to make migration simpler.
-     *
-     * **Default**: ```true```
-     *
-     * @type {boolean|undefined}
-     */
-    this.useVectorTypes = true
-
     /**
      * Specify the logging configuration for the driver. Object should have two properties `level` and `logger`.
      *