Installing node direct from url

Author: bigmontz

testkit/Dockerfile

@@ -3,13 +3,6 @@ FROM ubuntu:20.04
 ENV DEBIAN_FRONTEND noninteractive
 ENV NODE_OPTIONS --max_old_space_size=4096
 
-# Set bash as the shell
-SHELL ["/bin/bash", "--login", "-c"]
-
-# REPLACE shell with bash
-RUN rm /bin/sh && ln -s /bin/bash /bin/sh
-
-
 RUN apt-get update && \
     apt-get install -y \
         git \
@@ -40,14 +33,14 @@ RUN useradd -m driver && echo "driver:driver" | chpasswd && adduser driver sudo
 VOLUME /driver
 RUN chown -Rh driver:driver /driver
 RUN chown -Rh driver:driver /home/driver
-USER driver
 WORKDIR /home/driver
 
 # Configuring NodeJS version
-ENV NVM_DIR /home/driver/.nvm
-RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
-RUN nvm install ${NODE_VERSION:=10}
-RUN nvm alias default ${NODE_VERSION:=10}
-RUN nvm use default
-RUN hash -d npm
-RUN echo "source /home/driver/.nvm/nvm.sh" >> /home/driver/.bashrc
+RUN apt-get clean 
+RUN curl -sL https://deb.nodesource.com/setup_${NODE_VERSION:=12}.x | sh
+RUN apt-get install -y nodejs && rm -rf /var/lib/apt/lists/*
+
+USER driver
+
+RUN node --version
+RUN npm --version

testkit/common.py

@@ -23,7 +23,7 @@ def is_enabled(value):
 def run(args, env=None, cwd=None, check=True):
     cmd = ["/bin/bash", "--login", "-c", " ".join(args)]
     subprocess.run(
-        cmd, universal_newlines=True, stderr=sys.stderr, stdout=sys.stdout,
+        args, universal_newlines=True, stderr=sys.stderr, stdout=sys.stdout,
         check=check, env=env, cwd=cwd)
 
 
@@ -39,7 +39,7 @@ def run_in_driver_repo(args, env=None, check=True):
 
 def open_proccess_in_driver_repo(args, env=None):
     cmd = ["/bin/bash", "--login", "-c", " ".join(args)]
-    return subprocess.Popen(cmd, cwd=DRIVER_REPO, env=env, stderr=sys.stderr,
+    return subprocess.Popen(args, cwd=DRIVER_REPO, env=env, stderr=sys.stderr,
                             stdout=sys.stdout)