Checking if last message was login before send reset on verifyConnectivity

Author: bigmontz

packages/bolt-connection/src/bolt/bolt-protocol-v1.js

@@ -76,6 +76,7 @@ export default class BoltProtocol {
     this._log = log
     this._onProtocolError = onProtocolError
     this._fatalError = null
+    this._lastMessageSignature = null
   }
 
   /**
@@ -353,6 +354,8 @@ export default class BoltProtocol {
         this._log.debug(`C: ${message}`)
       }
 
+      this._lastMessageSignature = message.signature
+
       this.packer().packStruct(
         message.signature,
         message.fields.map(field => this.packer().packable(field))
@@ -366,6 +369,10 @@ export default class BoltProtocol {
     }
   }
 
+  isLastMessageLogin () {
+    return this._lastMessageSignature === 0x01
+  }
+
   /**
    * Notifies faltal erros to the observers and mark the protocol in the fatal error state.
    * @param {Error} error The error

packages/bolt-connection/src/connection-provider/connection-provider-pooled.js

@@ -123,7 +123,7 @@ export default class PooledConnectionProvider extends ConnectionProvider {
     const connection = await this._connectionPool.acquire(address)
     const serverInfo = new ServerInfo(connection.server, connection.protocol().version)
     try {
-      if (!connection._firstUsage) {
+      if (!connection._firstUsage && !connection.protocol().isLastMessageLogin()) {
         await connection.resetAndFlush()
       }
     } finally {

packages/bolt-connection/test/connection-provider/connection-provider-direct.test.js

@@ -251,7 +251,7 @@ describe('.verifyConnectivityAndGetServerInfo()', () => {
       const create = (address, release) => {
         const connection = new FakeConnection(address, release, server)
         connection.protocol = () => {
-          return { version: protocolVersion }
+          return { version: protocolVersion, isLastMessageLogin() { return false } }
         }
         connection.resetAndFlush = resetAndFlush
         if (releaseMock) {

packages/bolt-connection/test/connection-provider/connection-provider-routing.test.js

@@ -3112,7 +3112,8 @@ class FakeConnection extends Connection {
 
   protocol () {
     return {
-      version: this._protocolVersion
+      version: this._protocolVersion,
+      isLastMessageLogin: () => this._firstUsage
     }
   }
 }