Remove magic numbers

Author: bigmontz

packages/bolt-connection/src/bolt/bolt-protocol-v1.js

@@ -24,7 +24,7 @@ import {
 // eslint-disable-next-line no-unused-vars
 import { Chunker } from '../channel'
 import { structure, v1 } from '../packstream'
-import RequestMessage from './request-message'
+import RequestMessage, { SIGNATURES } from './request-message'
 import {
   LoginObserver,
   LogoffObserver,
@@ -475,12 +475,12 @@ export default class BoltProtocol {
   }
 
   isLastMessageLogon () {
-    return this._lastMessageSignature === 0x01 ||
-      this._lastMessageSignature === 0x6A
+    return this._lastMessageSignature === SIGNATURES.HELLO ||
+      this._lastMessageSignature === SIGNATURES.LOGON
   }
 
   isLastMessageReset () {
-    return this._lastMessageSignature === 0x0f
+    return this._lastMessageSignature === SIGNATURES.RESET
   }
 
   /**

packages/bolt-connection/src/bolt/request-message.js

@@ -51,6 +51,23 @@ const READ_MODE = 'r'
 
 const NO_STATEMENT_ID = -1
 
+const SIGNATURES = Object.freeze({
+  INIT,
+  RESET,
+  RUN,
+  PULL_ALL,
+  HELLO,
+  GOODBYE,
+  BEGIN,
+  COMMIT,
+  ROLLBACK,
+  ROUTE,
+  LOGON,
+  LOGOFF,
+  DISCARD,
+  PULL
+})
+
 export default class RequestMessage {
   constructor (signature, fields, toString) {
     this.signature = signature
@@ -376,3 +393,7 @@ const RESET_MESSAGE = new RequestMessage(RESET, [], () => 'RESET')
 const COMMIT_MESSAGE = new RequestMessage(COMMIT, [], () => 'COMMIT')
 const ROLLBACK_MESSAGE = new RequestMessage(ROLLBACK, [], () => 'ROLLBACK')
 const GOODBYE_MESSAGE = new RequestMessage(GOODBYE, [], () => 'GOODBYE')
+
+export {
+  SIGNATURES
+}

packages/neo4j-driver-deno/lib/bolt-connection/bolt/bolt-protocol-v1.js

@@ -24,7 +24,7 @@ import {
 // eslint-disable-next-line no-unused-vars
 import { Chunker } from '../channel/index.js'
 import { structure, v1 } from '../packstream/index.js'
-import RequestMessage from './request-message.js'
+import RequestMessage, { SIGNATURES } from './request-message.js'
 import {
   LoginObserver,
   LogoffObserver,
@@ -475,12 +475,12 @@ export default class BoltProtocol {
   }
 
   isLastMessageLogon () {
-    return this._lastMessageSignature === 0x01 ||
-      this._lastMessageSignature === 0x6A
+    return this._lastMessageSignature === SIGNATURES.HELLO ||
+      this._lastMessageSignature === SIGNATURES.LOGON
   }
 
   isLastMessageReset () {
-    return this._lastMessageSignature === 0x0f
+    return this._lastMessageSignature === SIGNATURES.RESET
   }
 
   /**

packages/neo4j-driver-deno/lib/bolt-connection/bolt/request-message.js

@@ -51,6 +51,23 @@ const READ_MODE = 'r'
 
 const NO_STATEMENT_ID = -1
 
+const SIGNATURES = Object.freeze({
+  INIT,
+  RESET,
+  RUN,
+  PULL_ALL,
+  HELLO,
+  GOODBYE,
+  BEGIN,
+  COMMIT,
+  ROLLBACK,
+  ROUTE,
+  LOGON,
+  LOGOFF,
+  DISCARD,
+  PULL
+})
+
 export default class RequestMessage {
   constructor (signature, fields, toString) {
     this.signature = signature
@@ -376,3 +393,7 @@ const RESET_MESSAGE = new RequestMessage(RESET, [], () => 'RESET')
 const COMMIT_MESSAGE = new RequestMessage(COMMIT, [], () => 'COMMIT')
 const ROLLBACK_MESSAGE = new RequestMessage(ROLLBACK, [], () => 'ROLLBACK')
 const GOODBYE_MESSAGE = new RequestMessage(GOODBYE, [], () => 'GOODBYE')
+
+export {
+  SIGNATURES
+}