Version 1 fix for user agent being empty

ConorNeo · ConorNeo · commit 3ee1fa6598b9 · 2023-04-05T16:07:51.000+01:00
diff --git a/packages/bolt-connection/src/bolt/bolt-protocol-v1.js b/packages/bolt-connection/src/bolt/bolt-protocol-v1.js
@@ -184,7 +184,7 @@ export default class BoltProtocol {
     // passing notification filter on this protocol version throws an error
     assertNotificationFilterIsEmpty(notificationFilter, this._onProtocolError, observer)
 
-    this.write(RequestMessage.init(userAgent || boltAgent, authToken), observer, true)
+    this.write(RequestMessage.init(userAgent === '' || userAgent == null ? boltAgent : userAgent, authToken), observer, true)
 
     return observer
   }

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ export default class BoltProtocol {`
`184`	`184`	`// passing notification filter on this protocol version throws an error`
`185`	`185`	`assertNotificationFilterIsEmpty(notificationFilter, this._onProtocolError, observer)`
`186`	`186`
`187`		`- this.write(RequestMessage.init(userAgent \|\| boltAgent, authToken), observer, true)`
	`187`	`+ this.write(RequestMessage.init(userAgent === '' \|\| userAgent == null ? boltAgent : userAgent, authToken), observer, true)`
`188`	`188`
`189`	`189`	`return observer`
`190`	`190`	`}`