Skip to content

Commit 3c87a27

Browse files
committed
Fix couple boltkit tests
They were failing because of incorrect artificial Neo4j version. Also fixes JS doc visibility modifier in driver.
1 parent 83e35fc commit 3c87a27

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/v1/driver.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class Driver {
6262
/**
6363
* Reference to the connection provider. Initialized lazily by {@link _getOrCreateConnectionProvider}.
6464
* @type {ConnectionProvider}
65-
* @private
65+
* @protected
6666
*/
6767
this._connectionProvider = null;
6868
}

test/resources/boltkit/read_server_with_version.script

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
!: AUTO PULL_ALL
33

44
C: INIT "neo4j-javascript/0.0.0-dev" {"credentials": "neo4j", "scheme": "basic", "principal": "neo4j"}
5-
S: SUCCESS {"server": "TheReadServerV1"}
5+
S: SUCCESS {"server": "Neo4j/8.8.8"}
66
C: RUN "MATCH (n) RETURN n.name" {}
77
PULL_ALL
88
S: SUCCESS {"fields": ["n.name"]}

test/resources/boltkit/write_server_with_version.script

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
!: AUTO PULL_ALL
33

44
C: INIT "neo4j-javascript/0.0.0-dev" {"credentials": "neo4j", "scheme": "basic", "principal": "neo4j"}
5-
S: SUCCESS {"server": "TheWriteServerV1"}
5+
S: SUCCESS {"server": "Neo4j/9.9.9"}
66
C: RUN "CREATE (n {name:'Bob'})" {}
77
PULL_ALL
88
S: SUCCESS {}

test/v1/routing.driver.boltkit.it.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -796,10 +796,10 @@ describe('routing driver', () => {
796796
readServer.exit(readServerExitCode => {
797797

798798
expect(readServerInfo.address).toBe('127.0.0.1:9005');
799-
expect(readServerInfo.version).toBe('TheReadServerV1');
799+
expect(readServerInfo.version).toBe('Neo4j/8.8.8');
800800

801801
expect(writeServerInfo.address).toBe('127.0.0.1:9007');
802-
expect(writeServerInfo.version).toBe('TheWriteServerV1');
802+
expect(writeServerInfo.version).toBe('Neo4j/9.9.9');
803803

804804
expect(routingServerExitCode).toEqual(0);
805805
expect(writeServerExitCode).toEqual(0);
@@ -852,10 +852,10 @@ describe('routing driver', () => {
852852
readServer.exit(readServerExitCode => {
853853

854854
expect(readSummary.server.address).toBe('127.0.0.1:9005');
855-
expect(readSummary.server.version).toBe('TheReadServerV1');
855+
expect(readSummary.server.version).toBe('Neo4j/8.8.8');
856856

857857
expect(writeSummary.server.address).toBe('127.0.0.1:9007');
858-
expect(writeSummary.server.version).toBe('TheWriteServerV1');
858+
expect(writeSummary.server.version).toBe('Neo4j/9.9.9');
859859

860860
expect(routingServerExitCode).toEqual(0);
861861
expect(writeServerExitCode).toEqual(0);

0 commit comments

Comments
 (0)