Extracted round robin load balancing strategy in a separate file

Author: lutovich

src/v1/internal/connection-providers.js

@@ -25,7 +25,7 @@ import Rediscovery from './rediscovery';
 import hasFeature from './features';
 import {DnsHostNameResolver, DummyHostNameResolver} from './host-name-resolvers';
 import RoutingUtil from './routing-util';
-import {RoundRobinLoadBalancingStrategy} from './load-balancing-strategies';
+import RoundRobinLoadBalancingStrategy from './round-robin-load-balancing-strategy';
 
 class ConnectionProvider {
 

src/v1/internal/load-balancing-strategies.js renamed to src/v1/internal/load-balancing-strategy.js

@@ -16,9 +16,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import RoundRobinArrayIndex from './round-robin-array-index';
 
-class LoadBalancingStrategy {
+
+/**
+ * A facility to select most appropriate reader or writer among the given addresses for request processing.
+ */
+export default class LoadBalancingStrategy {
 
   /**
    * Select next most appropriate reader from the list of given readers.
@@ -38,35 +41,3 @@ class LoadBalancingStrategy {
     throw new Error('Abstract function');
   }
 }
-
-export class RoundRobinLoadBalancingStrategy extends LoadBalancingStrategy {
-
-  constructor() {
-    super();
-    this._readersIndex = new RoundRobinArrayIndex();
-    this._writersIndex = new RoundRobinArrayIndex();
-  }
-
-  /**
-   * @inheritDoc
-   */
-  selectReader(knownReaders) {
-    return this._select(knownReaders, this._readersIndex);
-  }
-
-  /**
-   * @inheritDoc
-   */
-  selectWriter(knownWriters) {
-    return this._select(knownWriters, this._writersIndex);
-  }
-
-  _select(addresses, roundRobinIndex) {
-    const length = addresses.length;
-    if (length === 0) {
-      return null;
-    }
-    const index = roundRobinIndex.next(length);
-    return addresses[index];
-  }
-}

src/v1/internal/round-robin-load-balancing-strategy.js

@@ -0,0 +1,52 @@
+/**
+ * Copyright (c) 2002-2017 "Neo Technology,","
+ * Network Engine for Objects in Lund AB [http://neotechnology.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import RoundRobinArrayIndex from './round-robin-array-index';
+import LoadBalancingStrategy from './load-balancing-strategy';
+
+export default class RoundRobinLoadBalancingStrategy extends LoadBalancingStrategy {
+
+  constructor() {
+    super();
+    this._readersIndex = new RoundRobinArrayIndex();
+    this._writersIndex = new RoundRobinArrayIndex();
+  }
+
+  /**
+   * @inheritDoc
+   */
+  selectReader(knownReaders) {
+    return this._select(knownReaders, this._readersIndex);
+  }
+
+  /**
+   * @inheritDoc
+   */
+  selectWriter(knownWriters) {
+    return this._select(knownWriters, this._writersIndex);
+  }
+
+  _select(addresses, roundRobinIndex) {
+    const length = addresses.length;
+    if (length === 0) {
+      return null;
+    }
+    const index = roundRobinIndex.next(length);
+    return addresses[index];
+  }
+}

test/internal/load-balancing-strategies.test.js renamed to test/internal/round-robin-load-balancing-strategy.test.js

@@ -16,7 +16,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import {RoundRobinLoadBalancingStrategy} from '../../src/v1/internal/load-balancing-strategies';
+import RoundRobinLoadBalancingStrategy from '../../src/v1/internal/round-robin-load-balancing-strategy';
 
 describe('RoundRobinLoadBalancingStrategy', () => {