Skip to content

Commit 78c52b2

Browse files
committed
Reraise original error instead of RetryError
retry error is not helpful for enduser.
1 parent 66ddb01 commit 78c52b2

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

graphdatascience/query_runner/gds_arrow_client.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
stop_after_attempt,
3333
stop_after_delay,
3434
wait_exponential,
35-
wait_fixed,
3635
)
3736

3837
from graphdatascience.retry_utils.retry_utils import before_log
@@ -153,10 +152,11 @@ def connection_info(self) -> tuple[str, int]:
153152
return self._host, self._port
154153

155154
@retry(
155+
reraise=True,
156156
before=before_log("Request token", _arrow_client_logger, logging.DEBUG),
157157
retry=retry_any(retry_if_exception_type(FlightTimedOutError), retry_if_exception_type(FlightUnavailableError)),
158-
stop=stop_after_attempt(3),
159-
wait=wait_fixed(1),
158+
stop=(stop_after_delay(10) | stop_after_attempt(5)),
159+
wait=wait_exponential(multiplier=1, min=1, max=10),
160160
)
161161
def request_token(self) -> Optional[str]:
162162
"""
@@ -599,6 +599,7 @@ def _client(self) -> flight.FlightClient:
599599
return self._flight_client
600600

601601
@retry(
602+
reraise=True,
602603
before=before_log("Send action", _arrow_client_logger, logging.DEBUG),
603604
retry=retry_any(retry_if_exception_type(FlightTimedOutError), retry_if_exception_type(FlightUnavailableError)),
604605
stop=(stop_after_delay(10) | stop_after_attempt(5)),
@@ -621,6 +622,7 @@ def _send_action(self, action_type: str, meta_data: dict[str, Any]) -> dict[str,
621622
raise e # unreachable
622623

623624
@retry(
625+
reraise=True,
624626
before=before_log("Do put", _arrow_client_logger, logging.DEBUG),
625627
retry=retry_any(retry_if_exception_type(FlightTimedOutError), retry_if_exception_type(FlightUnavailableError)),
626628
stop=(stop_after_delay(10) | stop_after_attempt(5)),
@@ -652,6 +654,7 @@ def _upload_data(
652654
put_stream, ack_stream = self._safe_do_put(upload_descriptor, batches[0].schema)
653655

654656
@retry(
657+
reraise=True,
655658
before=before_log("Upload batch", _arrow_client_logger, logging.DEBUG),
656659
stop=(stop_after_delay(10) | stop_after_attempt(5)),
657660
wait=wait_exponential(multiplier=1, min=1, max=10),
@@ -674,6 +677,7 @@ def upload_batch(p: RecordBatch) -> None:
674677
GdsArrowClient.handle_flight_error(e)
675678

676679
@retry(
680+
reraise=True,
677681
before=before_log("Do get", _arrow_client_logger, logging.DEBUG),
678682
retry=retry_any(retry_if_exception_type(FlightTimedOutError), retry_if_exception_type(FlightUnavailableError)),
679683
stop=(stop_after_delay(10) | stop_after_attempt(5)),

graphdatascience/query_runner/protocol/project_protocols.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ def is_not_done(result: DataFrame) -> bool:
133133
logger = getLogger()
134134

135135
@retry(
136+
reraise=True,
136137
before=before_log(f"Projection (graph: `{params['graph_name']}`)", logger, DEBUG),
137138
retry=retry_if_result(is_not_done),
138139
wait=wait_incrementing(start=0.2, increment=0.2, max=2),

graphdatascience/query_runner/protocol/write_protocols.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ def is_not_completed(result: DataFrame) -> bool:
142142
logger = logging.getLogger()
143143

144144
@retry(
145+
reraise=True,
145146
retry=retry_if_result(is_not_completed),
146147
wait=wait_incrementing(start=0.2, increment=0.2, max=2),
147148
before=before_log(

0 commit comments

Comments
 (0)