Skip to content

Commit f9a74c7

Browse files
committed
build: always use three-component version numbers
Someone thought we didn't use semantic versioning because we said "6.4" instead of "6.4.0". Don't trim .0.
1 parent 3a83e41 commit f9a74c7

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

CHANGES.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ Unreleased
2828
.. _pull 1381: https://github.com/nedbat/coveragepy/pull/1381
2929

3030

31-
3231
.. _changes_64:
3332

3433
Version 6.4 — 2022-05-22

coverage/version.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
def _make_version(major, minor, micro, releaselevel, serial):
1212
"""Create a readable version string from version_info tuple components."""
1313
assert releaselevel in ['alpha', 'beta', 'candidate', 'final']
14-
version = "%d.%d" % (major, minor)
15-
if micro:
16-
version += ".%d" % (micro,)
14+
version = "%d.%d.%d" % (major, minor, micro)
1715
if releaselevel != 'final':
1816
short = {'alpha': 'a', 'beta': 'b', 'candidate': 'rc'}[releaselevel]
1917
version += f"{short}{serial}"

igor.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -385,12 +385,9 @@ def do_cheats():
385385
import coverage
386386
ver = coverage.__version__
387387
vi = coverage.version_info
388-
anchor = f"{vi[0]}{vi[1]}"
389-
if vi[2]:
390-
anchor += f"{vi[2]}"
388+
anchor = f"{vi[0]}-{vi[1]}-{vi[2]}"
391389
if vi[3] != "final":
392-
anchor += vi[3][0]
393-
anchor += f"{vi[4]}"
390+
anchor += f"{vi[3][0]}{vi[4]}"
394391
branch = subprocess.getoutput("git rev-parse --abbrev-ref @")
395392
print(f"Coverage version is {ver}")
396393

tests/test_version.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,10 @@ def test_version_info(self):
2121
assert coverage.version_info[3] in ['alpha', 'beta', 'candidate', 'final']
2222

2323
def test_make_version(self):
24-
assert _make_version(4, 0, 0, 'alpha', 0) == "4.0a0"
25-
assert _make_version(4, 0, 0, 'alpha', 1) == "4.0a1"
26-
assert _make_version(4, 0, 0, 'final', 0) == "4.0"
24+
assert _make_version(4, 0, 0, 'alpha', 0) == "4.0.0a0"
25+
assert _make_version(4, 0, 0, 'alpha', 1) == "4.0.0a1"
26+
assert _make_version(4, 0, 0, 'final', 0) == "4.0.0"
27+
assert _make_version(4, 1, 0, 'final', 0) == "4.1.0"
2728
assert _make_version(4, 1, 2, 'beta', 3) == "4.1.2b3"
2829
assert _make_version(4, 1, 2, 'final', 0) == "4.1.2"
2930
assert _make_version(5, 10, 2, 'candidate', 7) == "5.10.2rc7"

0 commit comments

Comments
 (0)