Skip to content

Commit fe08804

Browse files
committed
fix: rename package due to collisions with existing asset
1 parent ebee026 commit fe08804

File tree

16 files changed

+110
-97
lines changed

16 files changed

+110
-97
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ body:
4343
- type: input
4444
id: version
4545
attributes:
46-
label: Advanced Scene Manager Version
46+
label: Package Version
4747
description: The version of the package you are using
4848
placeholder: "e.g., 3.1.0"
4949
validations:

.github/ISSUE_TEMPLATE/feature_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ body:
66
attributes:
77
value: |
88
## Feature Request
9-
Have a feature idea? Let us know what you'd like to see in the Advanced Scene Manager!
9+
Have a feature idea? Let us know what you'd like to see in My Scene Manager!
1010
- type: input
1111
id: summary
1212
attributes:

.github/ISSUE_TEMPLATE/question.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ body:
66
attributes:
77
value: |
88
## Question or Support Request
9-
Need help or have a question about using the Advanced Scene Manager? Let us know!
9+
Need help or have a question about using My Scene Manager? Let us know!
1010
- type: textarea
1111
id: question
1212
attributes:
@@ -17,7 +17,7 @@ body:
1717
- type: input
1818
id: version
1919
attributes:
20-
label: Advanced Scene Manager Version
20+
label: Package Version
2121
description: The version of the package you are using
2222
placeholder: "e.g., 3.1.0"
2323
validations:

CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Our Pledge
44

5-
We, as contributors and maintainers of Advanced Scene Manager, pledge to make participation in our project and community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socioeconomic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
5+
We, as contributors and maintainers of My Scene Manager, pledge to make participation in our project and community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socioeconomic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
66

77
We are committed to fostering an open, welcoming, and inclusive community.
88

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Contribution Guide
22

3-
Thank you for considering contributing to Advanced Scene Manager! Whether you're fixing a bug, adding a feature, or improving the documentation, your contributions are greatly appreciated and help make the tool better for everyone.
3+
Thank you for considering contributing to My Scene Manager! Whether you're fixing a bug, adding a feature, or improving the documentation, your contributions are greatly appreciated and help make the tool better for everyone.
44

55
## How to Contribute
66

7-
There are several ways you can contribute to Advanced Scene Manager:
7+
There are several ways you can contribute to My Scene Manager:
88

99
### 1. Reporting Issues
1010

@@ -28,7 +28,7 @@ If you'd like to submit code to fix an issue or add a feature, please follow the
2828
Clone your forked repository to your local machine:
2929

3030
```bash
31-
git clone https://github.com/your-username/advanced-scene-manager.git
31+
git clone https://github.com/mygamedevtools/scene-loader.git
3232
```
3333

3434
#### Create a New Branch

Packages/com.mygamedevtools.scene-loader/Runtime/AdvancedSceneManager.cs renamed to Packages/com.mygamedevtools.scene-loader/Runtime/MySceneManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010

1111
namespace MyGameDevTools.SceneLoading
1212
{
13-
public static class AdvancedSceneManager
13+
public static class MySceneManager
1414
{
1515
internal static ISceneManager Instance
1616
{
1717
get
1818
{
1919
if (_instance == null)
20-
throw new NullReferenceException("[AdvancedSceneManager] The static Scene Manager instance is not available before the first scene is fully loaded. Try moving the call to `Start()`.");
20+
throw new NullReferenceException($"[{nameof(MySceneManager)}] The static Scene Manager instance is not available before the first scene is fully loaded. Try moving the call to `Start()`.");
2121
return _instance;
2222
}
2323
}

Packages/com.mygamedevtools.scene-loader/Samples/LoadingSceneExamples/Scripts/Editor/SceneBuildSettingsEditor.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ static void CheckScenesInBuildSettings()
4747
{
4848
bool addScenes = EditorUtility.DisplayDialogComplex(
4949
_sampleName,
50-
"To run the " + _sampleName + ", you need to add the sample scenes to the Build Settings. Would you like to add them now?\nYou can remove them later in the menu: \"Tools/Advanced Scene Manager/Remove '" + _sampleName + "' from Build Settings\".",
50+
"To run the " + _sampleName + ", you need to add the sample scenes to the Build Settings. Would you like to add them now?\nYou can remove them later in the menu: \"Tools/My Scene Manager/Remove '" + _sampleName + "' from Build Settings\".",
5151
"Add Scenes",
5252
"Ignore",
5353
"Don't Show Again"
@@ -83,7 +83,7 @@ static void AddScenesToBuildSettings(string[] scenes)
8383
EditorBuildSettings.scenes = currentScenes.ToArray();
8484
}
8585

86-
[MenuItem("Tools/Advanced Scene Manager/Remove '" + _sampleName + "' from Build Settings")]
86+
[MenuItem("Tools/My Scene Manager/Remove '" + _sampleName + "' from Build Settings")]
8787
static void RemoveSampleScenesFromBuildSettings()
8888
{
8989
List<EditorBuildSettingsScene> currentScenes = EditorBuildSettings.scenes.ToList();
@@ -92,7 +92,7 @@ static void RemoveSampleScenesFromBuildSettings()
9292
EditorBuildSettings.scenes = currentScenes.ToArray();
9393
}
9494

95-
[MenuItem("Tools/Advanced Scene Manager/Reset '" + _sampleName + "' Add Scenes Prompt")]
95+
[MenuItem("Tools/My Scene Manager/Reset '" + _sampleName + "' Add Scenes Prompt")]
9696
private static void ResetDontShowAgain()
9797
{
9898
EditorPrefs.DeleteKey(_dontShowAgainKey);

Packages/com.mygamedevtools.scene-loader/Samples/LoadingSceneExamples/Scripts/Runtime/SceneTransitionTrigger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ public class SceneTransitionTrigger : MonoBehaviour
1616
/// </summary>
1717
public void TransitionWithLoading(string loadingScene)
1818
{
19-
AdvancedSceneManager.TransitionAsync(_targetScene, loadingScene);
19+
MySceneManager.TransitionAsync(_targetScene, loadingScene);
2020
}
2121

2222
/// <summary>
2323
/// Triggers a Scene Transition to a scene with name provided by '<see cref="_targetScene"/>' without a loading scene.
2424
/// </summary>
2525
public void Transition()
2626
{
27-
AdvancedSceneManager.TransitionAsync(_targetScene);
27+
MySceneManager.TransitionAsync(_targetScene);
2828
}
2929
}

Packages/com.mygamedevtools.scene-loader/Tests/Runtime/AdvancedSceneManager_ExtensionTests.cs renamed to Packages/com.mygamedevtools.scene-loader/Tests/Runtime/StaticSceneManager_ExtensionTests.cs

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
namespace MyGameDevTools.SceneLoading.Tests
99
{
10-
public partial class AdvancedSceneManager_Tests
10+
public partial class StaticSceneManager_Tests
1111
{
1212
int[] _buildIndexes = new[] { 1, 2, 3 };
1313

@@ -29,132 +29,132 @@ public void AssetReferenceSetup()
2929
public IEnumerator Load_Extension_ByIndex()
3030
{
3131
var progress = new SimpleProgress();
32-
yield return Load_Template(() => AdvancedSceneManager.LoadAsync(1, true, progress), progress, 1, 0);
32+
yield return Load_Template(() => MySceneManager.LoadAsync(1, true, progress), progress, 1, 0);
3333
}
3434

3535
[UnityTest]
3636
public IEnumerator Load_Extension_ByIndex_Multiple()
3737
{
3838
var progress = new SimpleProgress();
39-
yield return Load_Template(() => AdvancedSceneManager.LoadAsync(_buildIndexes, 1, progress), progress, _buildIndexes.Length, 1);
39+
yield return Load_Template(() => MySceneManager.LoadAsync(_buildIndexes, 1, progress), progress, _buildIndexes.Length, 1);
4040
}
4141

4242
[UnityTest]
4343
public IEnumerator Load_Extension_ByName()
4444
{
4545
var progress = new SimpleProgress();
46-
yield return Load_Template(() => AdvancedSceneManager.LoadAsync(SceneBuilder.SceneNames[1], true, progress), progress, 1, 0);
46+
yield return Load_Template(() => MySceneManager.LoadAsync(SceneBuilder.SceneNames[1], true, progress), progress, 1, 0);
4747
}
4848

4949
[UnityTest]
5050
public IEnumerator Load_Extension_ByName_Multiple()
5151
{
5252
var progress = new SimpleProgress();
53-
yield return Load_Template(() => AdvancedSceneManager.LoadAsync(SceneBuilder.SceneNames, 1, progress), progress, SceneBuilder.SceneNames.Length, 1);
53+
yield return Load_Template(() => MySceneManager.LoadAsync(SceneBuilder.SceneNames, 1, progress), progress, SceneBuilder.SceneNames.Length, 1);
5454
}
5555

5656
#if ENABLE_ADDRESSABLES
5757
[UnityTest]
5858
public IEnumerator Load_Extension_Addressable_ByAddress()
5959
{
6060
var progress = new SimpleProgress();
61-
yield return Load_Template(() => AdvancedSceneManager.LoadAddressableAsync(SceneBuilder.SceneNames[1], true, progress), progress, 1, 0);
61+
yield return Load_Template(() => MySceneManager.LoadAddressableAsync(SceneBuilder.SceneNames[1], true, progress), progress, 1, 0);
6262
}
6363

6464
[UnityTest]
6565
public IEnumerator Load_Extension_Addressable_ByAddress_Multiple()
6666
{
6767
var progress = new SimpleProgress();
68-
yield return Load_Template(() => AdvancedSceneManager.LoadAddressableAsync(SceneBuilder.SceneNames, 1, progress), progress, SceneBuilder.SceneNames.Length, 1);
68+
yield return Load_Template(() => MySceneManager.LoadAddressableAsync(SceneBuilder.SceneNames, 1, progress), progress, SceneBuilder.SceneNames.Length, 1);
6969
}
7070

7171
[UnityTest]
7272
public IEnumerator Load_Extension_Addressable_ByAssetReference()
7373
{
7474
var progress = new SimpleProgress();
75-
yield return Load_Template(() => AdvancedSceneManager.LoadAddressableAsync(_assetReferences[1], true, progress), progress, 1, 0);
75+
yield return Load_Template(() => MySceneManager.LoadAddressableAsync(_assetReferences[1], true, progress), progress, 1, 0);
7676
}
7777

7878
[UnityTest]
7979
public IEnumerator Load_Extension_Addressable_ByAssetReference_Multiple()
8080
{
8181
var progress = new SimpleProgress();
82-
yield return Load_Template(() => AdvancedSceneManager.LoadAddressableAsync(_assetReferences, 1, progress), progress, _assetReferences.Length, 1);
82+
yield return Load_Template(() => MySceneManager.LoadAddressableAsync(_assetReferences, 1, progress), progress, _assetReferences.Length, 1);
8383
}
8484
#endif
8585

8686
[UnityTest]
8787
public IEnumerator Transition_Extension_ByIndex()
8888
{
89-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAsync(1, 1), 1, 0);
89+
yield return Transition_Template(() => MySceneManager.TransitionAsync(1, 1), 1, 0);
9090
}
9191

9292
[UnityTest]
9393
public IEnumerator Transition_Extension_ByIndex_Multiple()
9494
{
95-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAsync(_buildIndexes, 1), _buildIndexes.Length, 0);
95+
yield return Transition_Template(() => MySceneManager.TransitionAsync(_buildIndexes, 1), _buildIndexes.Length, 0);
9696
}
9797

9898
[UnityTest]
9999
public IEnumerator Transition_Extension_ByName()
100100
{
101-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAsync(SceneBuilder.SceneNames[1], SceneBuilder.SceneNames[0]), 1, 0);
101+
yield return Transition_Template(() => MySceneManager.TransitionAsync(SceneBuilder.SceneNames[1], SceneBuilder.SceneNames[0]), 1, 0);
102102
}
103103

104104
[UnityTest]
105105
public IEnumerator Transition_Extension_ByName_Multiple()
106106
{
107-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAsync(SceneBuilder.SceneNames, SceneBuilder.ScenePaths[0]), SceneBuilder.SceneNames.Length, 0);
107+
yield return Transition_Template(() => MySceneManager.TransitionAsync(SceneBuilder.SceneNames, SceneBuilder.ScenePaths[0]), SceneBuilder.SceneNames.Length, 0);
108108
}
109109

110110
#if ENABLE_ADDRESSABLES
111111
[UnityTest]
112112
public IEnumerator Transition_Extension_Addressable_ByAddress()
113113
{
114-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAddressableAsync(SceneBuilder.SceneNames[1], SceneBuilder.SceneNames[0]), 1, 0);
114+
yield return Transition_Template(() => MySceneManager.TransitionAddressableAsync(SceneBuilder.SceneNames[1], SceneBuilder.SceneNames[0]), 1, 0);
115115
}
116116

117117
[UnityTest]
118118
public IEnumerator Transition_Extension_Addressable_ByAddress_Multiple()
119119
{
120-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAddressableAsync(SceneBuilder.SceneNames, SceneBuilder.SceneNames[0]), SceneBuilder.SceneNames.Length, 0);
120+
yield return Transition_Template(() => MySceneManager.TransitionAddressableAsync(SceneBuilder.SceneNames, SceneBuilder.SceneNames[0]), SceneBuilder.SceneNames.Length, 0);
121121
}
122122

123123
[UnityTest]
124124
public IEnumerator Transition_Extension_Addressable_ByAssetReference()
125125
{
126-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAddressableAsync(_assetReferences[1], _assetReferences[0]), 1, 0);
126+
yield return Transition_Template(() => MySceneManager.TransitionAddressableAsync(_assetReferences[1], _assetReferences[0]), 1, 0);
127127
}
128128

129129
[UnityTest]
130130
public IEnumerator Transition_Extension_Addressable_ByAssetReference_Multiple()
131131
{
132-
yield return Transition_Template(() => AdvancedSceneManager.TransitionAddressableAsync(_assetReferences, _assetReferences[0]), SceneBuilder.SceneNames.Length, 0);
132+
yield return Transition_Template(() => MySceneManager.TransitionAddressableAsync(_assetReferences, _assetReferences[0]), SceneBuilder.SceneNames.Length, 0);
133133
}
134134
#endif
135135

136136
[UnityTest]
137137
public IEnumerator Unload_Extension_ByIndex()
138138
{
139-
yield return Unload_Template(() => AdvancedSceneManager.LoadAsync(1, true), () => AdvancedSceneManager.UnloadAsync(1), 1);
139+
yield return Unload_Template(() => MySceneManager.LoadAsync(1, true), () => MySceneManager.UnloadAsync(1), 1);
140140
}
141141

142142
[UnityTest]
143143
public IEnumerator Unload_Extension_ByIndex_Multiple()
144144
{
145-
yield return Unload_Template(() => AdvancedSceneManager.LoadAsync(_buildIndexes, 0), () => AdvancedSceneManager.UnloadAsync(_buildIndexes), _buildIndexes.Length);
145+
yield return Unload_Template(() => MySceneManager.LoadAsync(_buildIndexes, 0), () => MySceneManager.UnloadAsync(_buildIndexes), _buildIndexes.Length);
146146
}
147147

148148
[UnityTest]
149149
public IEnumerator Unload_Extension_ByName()
150150
{
151-
yield return Unload_Template(() => AdvancedSceneManager.LoadAsync(SceneBuilder.SceneNames[1], true), () => AdvancedSceneManager.UnloadAsync(SceneBuilder.SceneNames[1]), 1);
151+
yield return Unload_Template(() => MySceneManager.LoadAsync(SceneBuilder.SceneNames[1], true), () => MySceneManager.UnloadAsync(SceneBuilder.SceneNames[1]), 1);
152152
}
153153

154154
[UnityTest]
155155
public IEnumerator Unload_Extension_ByName_Multiple()
156156
{
157-
yield return Unload_Template(() => AdvancedSceneManager.LoadAsync(SceneBuilder.SceneNames, 0), () => AdvancedSceneManager.UnloadAsync(SceneBuilder.SceneNames), SceneBuilder.SceneNames.Length);
157+
yield return Unload_Template(() => MySceneManager.LoadAsync(SceneBuilder.SceneNames, 0), () => MySceneManager.UnloadAsync(SceneBuilder.SceneNames), SceneBuilder.SceneNames.Length);
158158
}
159159

160160
[UnityTest]
@@ -163,38 +163,38 @@ public IEnumerator Unload_Extension_ByScene_Multiple()
163163
Task<SceneResult> loadTask = Task.FromResult<SceneResult>(default);
164164
yield return Unload_Template(() =>
165165
{
166-
loadTask = AdvancedSceneManager.LoadAsync(SceneBuilder.SceneNames, 0);
166+
loadTask = MySceneManager.LoadAsync(SceneBuilder.SceneNames, 0);
167167
return loadTask;
168168
}, () =>
169169
{
170170
SceneResult result = loadTask.GetAwaiter().GetResult();
171-
return AdvancedSceneManager.UnloadAsync(result.GetScenes());
171+
return MySceneManager.UnloadAsync(result.GetScenes());
172172
}, SceneBuilder.SceneNames.Length);
173173
}
174174

175175
#if ENABLE_ADDRESSABLES
176176
[UnityTest]
177177
public IEnumerator Unload_Extension_Addressable_ByAddress()
178178
{
179-
yield return Unload_Template(() => AdvancedSceneManager.LoadAddressableAsync(SceneBuilder.SceneNames[1], true), () => AdvancedSceneManager.UnloadAddressableAsync(SceneBuilder.SceneNames[1]), 1);
179+
yield return Unload_Template(() => MySceneManager.LoadAddressableAsync(SceneBuilder.SceneNames[1], true), () => MySceneManager.UnloadAddressableAsync(SceneBuilder.SceneNames[1]), 1);
180180
}
181181

182182
[UnityTest]
183183
public IEnumerator Unload_Extension_Addressable_ByAddress_Multiple()
184184
{
185-
yield return Unload_Template(() => AdvancedSceneManager.LoadAddressableAsync(SceneBuilder.SceneNames, 0), () => AdvancedSceneManager.UnloadAddressableAsync(SceneBuilder.SceneNames), SceneBuilder.SceneNames.Length);
185+
yield return Unload_Template(() => MySceneManager.LoadAddressableAsync(SceneBuilder.SceneNames, 0), () => MySceneManager.UnloadAddressableAsync(SceneBuilder.SceneNames), SceneBuilder.SceneNames.Length);
186186
}
187187

188188
[UnityTest]
189189
public IEnumerator Unload_Extension_Addressable_ByAssetReference()
190190
{
191-
yield return Unload_Template(() => AdvancedSceneManager.LoadAddressableAsync(_assetReferences[1], true), () => AdvancedSceneManager.UnloadAddressableAsync(_assetReferences[1]), 1);
191+
yield return Unload_Template(() => MySceneManager.LoadAddressableAsync(_assetReferences[1], true), () => MySceneManager.UnloadAddressableAsync(_assetReferences[1]), 1);
192192
}
193193

194194
[UnityTest]
195195
public IEnumerator Unload_Extension_Addressable_ByAssetReference_Multiple()
196196
{
197-
yield return Unload_Template(() => AdvancedSceneManager.LoadAddressableAsync(_assetReferences, 0), () => AdvancedSceneManager.UnloadAddressableAsync(_assetReferences), _assetReferences.Length);
197+
yield return Unload_Template(() => MySceneManager.LoadAddressableAsync(_assetReferences, 0), () => MySceneManager.UnloadAddressableAsync(_assetReferences), _assetReferences.Length);
198198
}
199199
#endif
200200
}

0 commit comments

Comments
 (0)