Skip to content

Commit 5b8213f

Browse files
committed
IsPackable set via Directory.Build.props
1 parent 8d183cb commit 5b8213f

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed

Directory.Build.props

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,24 @@
11
<Project>
22
<PropertyGroup>
33
<MinClientVersion>2.12</MinClientVersion>
4-
<GenerateDocumentationFile Condition=" '$(Configuration)' == 'Release' ">true</GenerateDocumentationFile>
54
<Authors>MyCSharp.de, Benjamin Abt, Günther Foidl and Contributors</Authors>
65
<PackageProjectUrl>https://github.com/mycsharp/HttpUserAgentParser</PackageProjectUrl>
76
<PackageLicenseExpression>MIT</PackageLicenseExpression>
87
<DefaultLanguage>en-US</DefaultLanguage>
9-
<IsTestProject>$(MSBuildProjectName.Contains('Test'))</IsTestProject>
108
<Description>HTTP User Agent Parser for .NET</Description>
119
<NoPackageAnalysis>true</NoPackageAnalysis>
1210
<LangVersion>preview</LangVersion>
1311
<Nullable>enable</Nullable>
1412
<EmbedUntrackedSources>true</EmbedUntrackedSources>
1513
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1614
<DebugType>embedded</DebugType>
15+
<IsTestProject>$(MSBuildProjectName.Contains('Test'))</IsTestProject>
16+
<IsBenchmarkProject>$(MsBuildProjectName.Contains('Benchmark'))</IsBenchmarkProject>
1717
<IsPackable>false</IsPackable>
1818
</PropertyGroup>
19+
20+
<PropertyGroup Condition="'$(IsTestProject)' != 'true' AND '$(IsBenchmarkProject)' != 'true'">
21+
<IsPackable>true</IsPackable>
22+
<GenerateDocumentationFile Condition="'$(Configuration)' == 'Release'">true</GenerateDocumentationFile>
23+
</PropertyGroup>
1924
</Project>

src/MyCSharp.HttpUserAgentParser.AspNetCore/MyCSharp.HttpUserAgentParser.AspNetCore.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<Product>HTTP User Agent Parser Extensions for ASP.NET Core</Product>
55
<Description>HTTP User Agent Parser Extensions for ASP.NET Core</Description>
66
<TargetFramework>net5.0</TargetFramework>
7-
<IsPackable>true</IsPackable>
87
</PropertyGroup>
98

109
<ItemGroup>

src/MyCSharp.HttpUserAgentParser.MemoryCache/HttpUserAgentParserMemoryCachedProvider.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
namespace MyCSharp.HttpUserAgentParser.MemoryCache
88
{
9+
/// <inheritdoc/>
910
public class HttpUserAgentParserMemoryCachedProvider : IHttpUserAgentParserProvider
1011
{
1112
private readonly IMemoryCache _memoryCache;
@@ -17,6 +18,7 @@ public HttpUserAgentParserMemoryCachedProvider(IMemoryCache memoryCache, HttpUse
1718
_options = options;
1819
}
1920

21+
/// <inheritdoc/>
2022
public HttpUserAgentInformation Parse(string userAgent)
2123
{
2224
CacheKey key = this.GetKey(userAgent);

src/MyCSharp.HttpUserAgentParser.MemoryCache/MyCSharp.HttpUserAgentParser.MemoryCache.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<Product>HTTP User Agent Parser Extensions for IMemoryCache</Product>
55
<Description>HTTP User Agent Parser Extensions for IMemoryCache</Description>
66
<TargetFramework>netstandard2.1</TargetFramework>
7-
<IsPackable>true</IsPackable>
87
</PropertyGroup>
98

109
<ItemGroup>

src/MyCSharp.HttpUserAgentParser/MyCSharp.HttpUserAgentParser.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<Product>HTTP User Agent Parser</Product>
55
<Description>Parses user agents for Browser, Platform and Bots.</Description>
66
<TargetFramework>netstandard2.1</TargetFramework>
7-
<IsPackable>true</IsPackable>
87
</PropertyGroup>
98

109
<ItemGroup>
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,17 @@
1-
// Copyright © myCSharp 2020-2021, all rights reserved
1+
// Copyright © myCSharp 2020-2021, all rights reserved
22

33
namespace MyCSharp.HttpUserAgentParser.Providers
44
{
5+
/// <summary>
6+
/// Provides the basic parsing of user agent strings.
7+
/// </summary>
58
public interface IHttpUserAgentParserProvider
69
{
10+
/// <summary>
11+
/// Parsed the <paramref name="userAgent"/>-string.
12+
/// </summary>
13+
/// <param name="userAgent">The user agent to parse.</param>
14+
/// <returns>The parsed user agent information</returns>
715
HttpUserAgentInformation Parse(string userAgent);
816
}
9-
}
17+
}

0 commit comments

Comments
 (0)