Skip to content

Commit 8e18992

Browse files
committed
Better method name
1 parent ced7fcd commit 8e18992

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

src/main/java/org/mybatis/dynamic/sql/SqlTable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ protected SqlTable(String tableName) {
2929
this.tableName = Objects.requireNonNull(tableName);
3030
}
3131

32-
public String tableNameAtRuntime() {
32+
public String tableName() {
3333
return tableName;
3434
}
3535

src/main/java/org/mybatis/dynamic/sql/exception/DuplicateTableAliasException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@ public DuplicateTableAliasException(SqlTable table, String newAlias, String exis
4343
}
4444

4545
private static String generateMessage(SqlTable table, String newAlias, String existingAlias) {
46-
return Messages.getString("ERROR.1", table.tableNameAtRuntime(), newAlias, existingAlias); //$NON-NLS-1$
46+
return Messages.getString("ERROR.1", table.tableName(), newAlias, existingAlias); //$NON-NLS-1$
4747
}
4848
}

src/main/java/org/mybatis/dynamic/sql/insert/render/InsertRenderingUtilities.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ public static String calculateInsertStatement(SqlTable table, FieldAndValueColle
3131
}
3232

3333
public static String calculateInsertStatementStart(SqlTable table) {
34-
return "insert into " + table.tableNameAtRuntime(); //$NON-NLS-1$
34+
return "insert into " + table.tableName(); //$NON-NLS-1$
3535
}
3636
}

src/main/java/org/mybatis/dynamic/sql/render/GuaranteedTableAliasCalculator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public Optional<String> aliasForColumn(SqlTable table) {
3838
if (alias.isPresent()) {
3939
return alias;
4040
} else {
41-
return Optional.of(table.tableNameAtRuntime());
41+
return Optional.of(table.tableName());
4242
}
4343
}
4444

src/main/java/org/mybatis/dynamic/sql/render/RenderingContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ public <T> String aliasedColumnName(SqlColumn<T> column, String explicitAlias) {
8888

8989
public String aliasedTableName(SqlTable table) {
9090
return tableAliasCalculator.aliasForTable(table)
91-
.map(a -> table.tableNameAtRuntime() + spaceBefore(a))
92-
.orElseGet(table::tableNameAtRuntime);
91+
.map(a -> table.tableName() + spaceBefore(a))
92+
.orElseGet(table::tableName);
9393
}
9494

9595
public boolean isNonRenderingClauseAllowed() {

src/test/java/examples/joins/JoinMapperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,7 +957,7 @@ void testSelfWithDuplicateAlias() {
957957
.from(user, "u1");
958958

959959
assertThatExceptionOfType(DuplicateTableAliasException.class).isThrownBy(() -> dsl.join(user, "u2"))
960-
.withMessage(Messages.getString("ERROR.1", user.tableNameAtRuntime(), "u2", "u1"));
960+
.withMessage(Messages.getString("ERROR.1", user.tableName(), "u2", "u1"));
961961
}
962962

963963
@Test

0 commit comments

Comments
 (0)