Skip to content

Commit 22e75b1

Browse files
committed
Use Predicate.not for readability
1 parent f887c34 commit 22e75b1

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

src/site/markdown/docs/conditions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ any null or blank string, and you want to trim all strings. This can be accompli
267267
.where(animalName, isIn(" Mouse", " ", null, "", "Musk shrew ")
268268
.filter(Objects::nonNull)
269269
.map(String::trim)
270-
.filter(st -> !st.isEmpty()))
270+
.filter(not(String::isEmpty)))
271271
.orderBy(id)
272272
.build()
273273
.render(RenderingStrategies.MYBATIS3);
@@ -284,7 +284,7 @@ public class MyInCondition {
284284
return SqlBuilder.isIn(values)
285285
.filter(Objects::nonNull)
286286
.map(String::trim)
287-
.filter(st -> !st.isEmpty());
287+
.filter(not(String::isEmpty));
288288
}
289289
}
290290
```

src/test/java/examples/animal/data/MyInCondition.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
package examples.animal.data;
1717

18+
import static java.util.function.Predicate.not;
19+
1820
import java.util.Objects;
1921

2022
import org.mybatis.dynamic.sql.SqlBuilder;
@@ -25,6 +27,6 @@ public static IsIn<String> isIn(String...values) {
2527
return SqlBuilder.isIn(values)
2628
.filter(Objects::nonNull)
2729
.map((String::trim))
28-
.filter(st -> !st.isEmpty());
30+
.filter(not(String::isEmpty));
2931
}
3032
}

src/test/java/examples/animal/data/OptionalConditionsWithPredicatesAnimalDataTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static examples.animal.data.AnimalDataDynamicSqlSupport.bodyWeight;
2121
import static examples.animal.data.AnimalDataDynamicSqlSupport.brainWeight;
2222
import static examples.animal.data.AnimalDataDynamicSqlSupport.id;
23+
import static java.util.function.Predicate.not;
2324
import static org.assertj.core.api.Assertions.assertThat;
2425
import static org.junit.jupiter.api.Assertions.assertAll;
2526
import static org.mybatis.dynamic.sql.SqlBuilder.*;
@@ -484,7 +485,7 @@ void testValueStreamTransformer() {
484485
.where(animalName, isIn(" Mouse", " ", null, "", "Musk shrew ")
485486
.filter(Objects::nonNull)
486487
.map(String::trim)
487-
.filter(st -> !st.isEmpty()))
488+
.filter(not(String::isEmpty)))
488489
.orderBy(id)
489490
.build()
490491
.render(RenderingStrategies.MYBATIS3);

0 commit comments

Comments
 (0)