Skip to content

Commit c8ff596

Browse files
committed
Revert changes on PropertParser for applying review comment of gh-2886
1 parent 2b3f932 commit c8ff596

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/main/java/org/apache/ibatis/builder/annotation/MapperAnnotationBuilder.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,9 @@ private <T> T parseStringValue(String valueString, T fallbackValue, Function<Str
381381
if (valueString.isEmpty()) {
382382
return fallbackValue;
383383
} else {
384-
Properties defaults = new Properties();
384+
Properties variables = new Properties();
385385
Optional.ofNullable(fallbackValue).map(String::valueOf)
386-
.ifPresent(x -> defaults.setProperty(TOKEN_PARSER.parse(valueString), x));
387-
Properties variables = new Properties(defaults);
386+
.ifPresent(x -> variables.setProperty(TOKEN_PARSER.parse(valueString), x));
388387
variables.putAll(configuration.getVariables());
389388
return Optional.ofNullable(PropertyParser.parse(valueString, variables)).map(valueTypeConverter)
390389
.orElse(fallbackValue);

src/main/java/org/apache/ibatis/parsing/PropertyParser.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,8 @@ public String handleToken(String content) {
8888
return variables.getProperty(key, defaultValue);
8989
}
9090
}
91-
String value = variables.getProperty(key);
92-
if (value != null) {
93-
return value;
91+
if (variables.containsKey(key)) {
92+
return variables.getProperty(key);
9493
}
9594
}
9695
return "${" + content + "}";

0 commit comments

Comments
 (0)