[FIX] Memory was not being freed properly for IFP Version 2, fixed it by adding a check. Also the loop for sequences in unloadIFP was incorrect, fixed that as well. Tested by checking the pointers and frees the memory properly now

Author: codenulls

Client/mods/deathmatch/logic/CClientIFP.cpp

@@ -45,11 +45,20 @@ void CClientIFP::UnloadIFP ( void )
     for ( size_t i = 0; i < m_Animations.size(); i++ )
     {
         IFP_Animation * ifpAnimation = &m_Animations[i];
-        for (unsigned short SequenceIndex = 0; i < ifpAnimation->Hierarchy.m_nSeqCount; i++)
+        if ( isVersion1 )
+        { 
+            for (unsigned short SequenceIndex = 0; SequenceIndex < ifpAnimation->Hierarchy.m_nSeqCount; SequenceIndex++)
+            {
+                
+                _CAnimBlendSequence * pSequence = (_CAnimBlendSequence*)((BYTE*)ifpAnimation->Hierarchy.m_pSequences + (sizeof(_CAnimBlendSequence) * SequenceIndex));
+                free ( pSequence->m_pFrames );
+            }
+        }
+        else
         {
-            _CAnimBlendSequence * pSequence = (_CAnimBlendSequence*)((BYTE*)(ifpAnimation->Hierarchy.m_pSequences) + (sizeof(_CAnimBlendSequence) * SequenceIndex));
-            free ( pSequence->m_pFrames );
+            free ( ifpAnimation->pFramesMemoryVersion2 );
         }
+
         delete ifpAnimation->pSequencesMemory;
     }
 
@@ -135,6 +144,8 @@ void CClientIFP::ReadIFPVersion2( bool anp3)
             pAnimHierarchy->m_bRunningCompressed = AnimationNode.isCompressed & 1;
 
             pKeyFrames = (unsigned char*)malloc(AnimationNode.FrameSize);
+
+            ifpAnimation.pFramesMemoryVersion2 = pKeyFrames;
         }
 
         OLD__CAnimBlendHierarchy_SetName(pAnimHierarchy, AnimationNode.Name);

Client/mods/deathmatch/logic/IFP/IFPLoader.h

@@ -137,6 +137,7 @@ struct IFP_Animation
     _CAnimBlendHierarchy              Hierarchy;
     //std::vector <_CAnimBlendSequence> Sequences;
     char *                            pSequencesMemory;
+    unsigned char*                    pFramesMemoryVersion2; // only for IFP version 2;
 };
 
 struct Animation